You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
Wladimir J. van der Laan 7b13c64645
Merge #15642: [rpc] Remove deprecated rpc warnings
6 years ago
..
data
test_framework qa: mininode: Clearer error message on invalid magic bytes 6 years ago
.gitignore
README.md
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Update copyright in ./test 6 years ago
feature_assumevalid.py scripted-diff: Update copyright in ./test 6 years ago
feature_bip68_sequence.py scripted-diff: Update copyright in ./test 6 years ago
feature_block.py scripted-diff: test: Remove brackets after assert 6 years ago
feature_blocksdir.py
feature_cltv.py wallet/rpc: add maxfeerate parameter to testmempoolaccept 6 years ago
feature_config_args.py Merge #14954: build: Require python 3.5 6 years ago
feature_csv_activation.py scripted-diff: Update copyright in ./test 6 years ago
feature_dbcrash.py test: Remove python3.4 workaround in feature_dbcrash 6 years ago
feature_dersig.py wallet/rpc: add maxfeerate parameter to testmempoolaccept 6 years ago
feature_fee_estimation.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
feature_filelock.py
feature_help.py
feature_includeconf.py
feature_logging.py
feature_maxuploadtarget.py
feature_minchainwork.py
feature_notifications.py scripted-diff: Update copyright in ./test 6 years ago
feature_nulldummy.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
feature_proxy.py scripted-diff: Update copyright in ./test 6 years ago
feature_pruning.py scripted-diff: Update copyright in ./test 6 years ago
feature_rbf.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
feature_reindex.py
feature_segwit.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
feature_shutdown.py
feature_uacomment.py
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 6 years ago
interface_bitcoin_cli.py Merge #15564: cli: remove duplicate wallet fields from -getinfo 6 years ago
interface_http.py scripted-diff: Update copyright in ./test 6 years ago
interface_rest.py scripted-diff: Update copyright in ./test 6 years ago
interface_rpc.py scripted-diff: Update copyright in ./test 6 years ago
interface_zmq.py scripted-diff: Update copyright in ./test 6 years ago
mempool_accept.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
mempool_limit.py scripted-diff: Update copyright in ./test 6 years ago
mempool_packages.py scripted-diff: Update copyright in ./test 6 years ago
mempool_persist.py
mempool_reorg.py
mempool_resurrect.py scripted-diff: Update copyright in ./test 6 years ago
mempool_spend_coinbase.py
mining_basic.py scripted-diff: test: Use py3.5 bytes::hex() method 6 years ago
mining_getblocktemplate_longpoll.py scripted-diff: Update copyright in ./test 6 years ago
mining_prioritisetransaction.py scripted-diff: Update copyright in ./test 6 years ago
p2p_compactblocks.py scripted-diff: Update copyright in ./test 6 years ago
p2p_disconnect_ban.py
p2p_feefilter.py scripted-diff: Update copyright in ./test 6 years ago
p2p_fingerprint.py
p2p_invalid_block.py
p2p_invalid_locator.py
p2p_invalid_messages.py
p2p_invalid_tx.py
p2p_leak.py scripted-diff: Update copyright in ./test 6 years ago
p2p_leak_tx.py
p2p_mempool.py
p2p_node_network_limited.py
p2p_segwit.py scripted-diff: Update copyright in ./test 6 years ago
p2p_sendheaders.py
p2p_timeouts.py
p2p_unrequested_blocks.py scripted-diff: Update copyright in ./test 6 years ago
rpc_bind.py scripted-diff: Update copyright in ./test 6 years ago
rpc_blockchain.py scripted-diff: Update copyright in ./test 6 years ago
rpc_createmultisig.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
rpc_decodescript.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deprecated.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deriveaddresses.py scripted-diff: Update copyright in ./test 6 years ago
rpc_fundrawtransaction.py scripted-diff: Update copyright in ./test 6 years ago
rpc_getblockstats.py scripted-diff: Update copyright in ./test 6 years ago
rpc_getchaintips.py
rpc_help.py
rpc_invalidateblock.py
rpc_misc.py modify test for memory locked in case locking pages failed at some point 6 years ago
rpc_named_arguments.py scripted-diff: Update copyright in ./test 6 years ago
rpc_net.py
rpc_preciousblock.py scripted-diff: Update copyright in ./test 6 years ago
rpc_psbt.py rpc: return a number for estimated_feerate in analyzepsbt 6 years ago
rpc_rawtransaction.py wallet/rpc: add maxfeerate parameter to testmempoolaccept 6 years ago
rpc_scantxoutset.py scripted-diff: Update copyright in ./test 6 years ago
rpc_signmessage.py scripted-diff: Update copyright in ./test 6 years ago
rpc_signrawtransaction.py [rpc] Remove signrawtransaction warning 6 years ago
rpc_txoutproof.py
rpc_uptime.py scripted-diff: Update copyright in ./test 6 years ago
rpc_users.py
test_runner.py Merge #15466: tests: Print remaining jobs in test_runner.py 6 years ago
tool_wallet.py
wallet_abandonconflict.py Address test todos by removing -txindex to nodes. 6 years ago
wallet_address_types.py scripted-diff: Update copyright in ./test 6 years ago
wallet_backup.py
wallet_balance.py
wallet_basic.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
wallet_bumpfee.py scripted-diff: Update copyright in ./test 6 years ago
wallet_coinbase_category.py
wallet_create_tx.py scripted-diff: Update copyright in ./test 6 years ago
wallet_createwallet.py scripted-diff: Update copyright in ./test 6 years ago
wallet_disable.py scripted-diff: Update copyright in ./test 6 years ago
wallet_dump.py scripted-diff: Update copyright in ./test 6 years ago
wallet_encryption.py
wallet_fallbackfee.py
wallet_groups.py
wallet_hd.py scripted-diff: Update copyright in ./test 6 years ago
wallet_import_rescan.py
wallet_import_with_label.py
wallet_importmulti.py scripted-diff: Update copyright in ./test 6 years ago
wallet_importprunedfunds.py
wallet_keypool.py scripted-diff: Update copyright in ./test 6 years ago
wallet_keypool_topup.py scripted-diff: Update copyright in ./test 6 years ago
wallet_labels.py
wallet_listreceivedby.py
wallet_listsinceblock.py
wallet_listtransactions.py wallet/rpc: add maxfeerate parameter to sendrawtransaction 6 years ago
wallet_multiwallet.py scripted-diff: Update copyright in ./test 6 years ago
wallet_resendwallettransactions.py
wallet_txn_clone.py scripted-diff: Update copyright in ./test 6 years ago
wallet_txn_doublespend.py scripted-diff: Update copyright in ./test 6 years ago
wallet_zapwallettxes.py

README.md

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: