You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
MarcoFalke 1111bb91f5
test: Reformat python imports to aid scripted diff
5 years ago
..
data Merge #16551: test: Test that low difficulty chain fork is rejected 5 years ago
test_framework Merge #16551: test: Test that low difficulty chain fork is rejected 5 years ago
.gitignore
README.md qa: Add tool-prefix to functional test readme 6 years ago
combine_logs.py test/contrib: Fix invalid escapes in regex strings 5 years ago
combined_log_template.html
create_cache.py
example_test.py [qa] Fix race condition in example_test.py 5 years ago
feature_abortnode.py [qa] Test disconnect block failure -> shutdown 6 years ago
feature_assumevalid.py test: Fix “local variable 'e' is assigned to but never used” 5 years ago
feature_bip68_sequence.py [Consensus] Bury CSV deployment height 5 years ago
feature_block.py Merge #16363: test: Add test for BIP30 duplicate tx 5 years ago
feature_blocksdir.py test: Adapt test framework for chains other than "regtest" 5 years ago
feature_cltv.py [rpc] Tidy up reporting of buried and ongoing softforks 5 years ago
feature_config_args.py Merge #15864: Fix datadir handling 5 years ago
feature_csv_activation.py [Consensus] Bury CSV deployment height 5 years ago
feature_dbcrash.py refactor: pcoinsTip -> CChainState::CoinsTip() 5 years ago
feature_dersig.py [rpc] Tidy up reporting of buried and ongoing softforks 5 years ago
feature_fee_estimation.py test: Explain why -whitelist is used in feature_fee_estimation 5 years ago
feature_filelock.py QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core 6 years ago
feature_help.py
feature_includeconf.py init: Use InitError for all errors in bitcoind/qt 5 years ago
feature_logging.py test/contrib: Fix invalid escapes in regex strings 5 years ago
feature_maxuploadtarget.py test: Require standard txs in regtest 5 years ago
feature_minchainwork.py
feature_notifications.py test: Reformat python imports to aid scripted diff 5 years ago
feature_nulldummy.py [Consensus] Bury segwit deployment 5 years ago
feature_proxy.py scripted-diff: Update copyright in ./test 6 years ago
feature_pruning.py test: Add missing sync_blocks to feature_pruning 5 years ago
feature_rbf.py test: Require standard txs in regtest 5 years ago
feature_reindex.py
feature_segwit.py qa: Add RPC tests for weight in mempool entry 5 years ago
feature_shutdown.py qa: Remove race between connecting and shutdown on separate connections 6 years ago
feature_uacomment.py test/contrib: Fix invalid escapes in regex strings 5 years ago
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 6 years ago
interface_bitcoin_cli.py test: Adapt test framework for chains other than "regtest" 5 years ago
interface_http.py scripted-diff: Update copyright in ./test 6 years ago
interface_rest.py scripted-diff: Update copyright in ./test 6 years ago
interface_rpc.py Add a 'logpath' field to getrpcinfo 6 years ago
interface_zmq.py qa: Relax so that the subscriber is ready before publishing zmq messages 5 years ago
mempool_accept.py test: Require standard txs in regtest 5 years ago
mempool_limit.py test: Require standard txs in regtest 5 years ago
mempool_package_onemore.py Conservatively accept RBF bumps bumping one tx at the package limits 5 years ago
mempool_packages.py test: Remove unused imports 6 years ago
mempool_persist.py rpc: Expose g_is_mempool_loaded via getmempoolinfo and /rest/mempool/info.json 6 years ago
mempool_reorg.py
mempool_resurrect.py scripted-diff: Update copyright in ./test 6 years ago
mempool_spend_coinbase.py
mining_basic.py scripted-diff: test: Use py3.5 bytes::hex() method 6 years ago
mining_getblocktemplate_longpoll.py scripted-diff: Update copyright in ./test 6 years ago
mining_prioritisetransaction.py test: Require standard txs in regtest 5 years ago
p2p_blocksonly.py Disconnect peers violating blocks-only mode 5 years ago
p2p_compactblocks.py [Consensus] Bury segwit deployment 5 years ago
p2p_disconnect_ban.py rpc: Correctly name arguments 6 years ago
p2p_dos_header_tree.py test: Test that low difficulty chain fork is rejected 5 years ago
p2p_feefilter.py test: Remove unused imports 6 years ago
p2p_fingerprint.py
p2p_invalid_block.py qa: Avoid race in p2p_invalid_block by waiting for the block request 6 years ago
p2p_invalid_locator.py Update copyright headers to 2018 6 years ago
p2p_invalid_messages.py test: Skip flaky p2p_invalid_messages test on macOS 5 years ago
p2p_invalid_tx.py test: Require standard txs in regtest 5 years ago
p2p_leak.py scripted-diff: Update copyright in ./test 6 years ago
p2p_leak_tx.py [tests] Test that nodes respond to getdata with notfound 6 years ago
p2p_mempool.py
p2p_node_network_limited.py Disable bloom filtering by default. 6 years ago
p2p_permissions.py Reformat p2p_permissions.py 5 years ago
p2p_segwit.py [Consensus] Bury segwit deployment 5 years ago
p2p_sendheaders.py test: Remove unused imports 6 years ago
p2p_timeouts.py test: Avoid racy test p2p_timeouts 6 years ago
p2p_tx_download.py [qa] Test that getdata requests work as expected 5 years ago
p2p_unrequested_blocks.py test: Remove unused imports 6 years ago
rpc_bind.py test: Adapt test framework for chains other than "regtest" 5 years ago
rpc_blockchain.py Add window final block height to getchaintxstats 5 years ago
rpc_createmultisig.py signrawtransactionwithkey: better error messages for bad redeemScript/witnessScript 5 years ago
rpc_decodescript.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deprecated.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deriveaddresses.py Give more errors for specific failure conditions 5 years ago
rpc_fundrawtransaction.py test: Split fundrawtx test into subtests 5 years ago
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 6 years ago
rpc_getblockstats.py rpc: faster getblockstats using BlockUndo data 6 years ago
rpc_getchaintips.py test: Remove unused imports 6 years ago
rpc_help.py qa: Add test to ensure node can generate all help texts at runtime 6 years ago
rpc_invalidateblock.py test: Establish only one connection between nodes in rpc_invalidateblock 5 years ago
rpc_misc.py tests: Fail if RPC has been added without tests 6 years ago
rpc_named_arguments.py scripted-diff: Update copyright in ./test 6 years ago
rpc_net.py tests: rename 'test_getnetworkinginfo' in 'test_getnetworkinfo' 5 years ago
rpc_preciousblock.py test: Remove unused imports 6 years ago
rpc_psbt.py [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 5 years ago
rpc_rawtransaction.py test: Reformat python imports to aid scripted diff 5 years ago
rpc_scantxoutset.py qa: Check scantxoutset result against gettxoutsetinfo 5 years ago
rpc_setban.py test: Remove incorrect and unused try-block in assert_debug_log 5 years ago
rpc_signmessage.py scripted-diff: Update copyright in ./test 6 years ago
rpc_signrawtransaction.py [rpc] Remove signrawtransaction warning 6 years ago
rpc_txoutproof.py
rpc_uptime.py scripted-diff: Update copyright in ./test 6 years ago
rpc_users.py test: rpc_users: Make variable names more clear. 5 years ago
test_runner.py Merge #16551: test: Test that low difficulty chain fork is rejected 5 years ago
tool_wallet.py test: Tool wallet test coverage for unexpected writes to wallet 5 years ago
wallet_abandonconflict.py test: Remove unused imports 6 years ago
wallet_address_types.py Add unmodified-but-with-checksum to getdescriptorinfo 5 years ago
wallet_avoidreuse.py wallet/rpc/getbalances: add entry for 'mine.used' balance in results 5 years ago
wallet_backup.py test: Remove unused imports 6 years ago
wallet_balance.py test: Add missing sync_all to wallet_balance test 5 years ago
wallet_basic.py test: improve gettransaction test coverage 5 years ago
wallet_bumpfee.py deprecate totalFee argument in bumpfee RPC call 5 years ago
wallet_bumpfee_totalfee_deprecation.py Add RPC bumpfee totalFee deprecation test 5 years ago
wallet_coinbase_category.py Test coinbase category in wallet rpcs 6 years ago
wallet_create_tx.py test: Add test for maxtxfee option 5 years ago
wallet_createwallet.py Allow createwallet to take empty passwords to make unencrypted wallets 5 years ago
wallet_disable.py scripted-diff: Update copyright in ./test 6 years ago
wallet_dump.py scripted-diff: Update copyright in ./test 6 years ago
wallet_encryption.py QA: Fix race condition in wallet_encryption test 5 years ago
wallet_fallbackfee.py
wallet_groups.py scripted-diff: Rename rpc_timewait to rpc_timeout 6 years ago
wallet_hd.py scripted-diff: Update copyright in ./test 6 years ago
wallet_import_rescan.py test: Test p2sh-witness and bech32 in wallet_import_rescan 5 years ago
wallet_import_with_label.py [tests] move wallet util functions to wallet_util.py 6 years ago
wallet_importmulti.py Avoid using mutable default parameter values 5 years ago
wallet_importprunedfunds.py rpc: Correctly name arguments 6 years ago
wallet_keypool.py scripted-diff: Update copyright in ./test 6 years ago
wallet_keypool_topup.py test: Remove unused imports 6 years ago
wallet_labels.py [tests] Small fixups before deprecating generate 6 years ago
wallet_listreceivedby.py test: Remove unused imports 6 years ago
wallet_listsinceblock.py test: Remove unused imports 6 years ago
wallet_listtransactions.py test: Remove unused imports 6 years ago
wallet_multiwallet.py Merge #16796: wallet: Fix segfault in CreateWalletFromFile 5 years ago
wallet_reorgsrestore.py Add a test wallet_reorgsrestore 5 years ago
wallet_resendwallettransactions.py rpc: Clarify that block count means height excl genesis 5 years ago
wallet_txn_clone.py test: Remove unused imports 6 years ago
wallet_txn_doublespend.py test: Remove unused imports 6 years ago
wallet_watchonly.py test: add executable flag for wallet_watchonly.py 5 years ago
wallet_zapwallettxes.py

README.md

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: