History

Wladimir J. van der Laan 5924dadc2f Merge #13671 : Remove the boost/algorithm/string/case_conv.hpp dependency `b193d5a443` Removes the Boost case_conv.hpp dependency. (251) `7a208d9fad` Implements custom tolower and toupper functions. (251) `e2ba043b8d` Implements ParseNetwork unit test. (251) Pull request description: This pull request removes the `boost/algorithm/string/case_conv.hpp` dependency from the project. `boost/algorithm/string/case_conv.hpp` is included for the `boost::to_lower` and `boost::to_upper` template functions. We can replace the calls to these functions with straightforward alternative implementations that use the C++ Standard Library, because the functions are called with `std::string` objects that use standard 7-bit ASCII characters as argument. The refactored implementation should work without the explicit `static_cast<unsigned char>` cast and `unsigned char` lambda return type. Both have been added defensively and to be explicit. Especially in case of the former, behaviour is undefined (potentially result in a crash) if the `std::toupper` argument is not an `unsigned char`. A potential alternative, maybe even preferred, implementation to address the `boost::to_lower` function call in `ParseNetwork(std::string)` could have been: ```c++ if (net == "ipv4" \|\| net == "IPv4") return NET_IPV4; if (net == "ipv6" \|\| net == "IPv6") return NET_IPV6; ``` This alternative implementation would however change the external behaviour of `ParseNetwork(std::string)`. This pull requests includes a unit test to validate the implementation of `ParseNetwork(std::string)` prior and after the removal of the `case_conv.hpp` dependency. `boost/algorithm/string/case_conv.hpp` has been removed from the `EXPECTED_BOOST_INCLUDES` in `test/lint/lint-includes.sh` because it is no longer required. Tree-SHA512: d803ae709f2368a3efb223097384a722436955bce0c44a1a5cffd0abb3164be0cce85ba0e9ebd9408166df3f1a95ea0c0d29e3a2534af2fae206c0419d67fde9		6 years ago
..
README.md	…
check-doc.py	…
check-rpc-mappings.py	Merge #13707 : tests: Add usage note to check-rpc-mappings.py	6 years ago
commit-script-check.sh	…
git-subtree-check.sh	…
lint-all.sh	…
lint-circular-dependencies.sh	…
lint-filenames.sh	…
lint-format-strings.py	…
lint-format-strings.sh	…
lint-include-guards.sh	…
lint-includes.sh	Merge #13671 : Remove the boost/algorithm/string/case_conv.hpp dependency	6 years ago
lint-locale-dependence.sh	Removes the Boost case_conv.hpp dependency.	6 years ago
lint-logs.sh	…
lint-python-shebang.sh	…
lint-python-utf8-encoding.sh	…
lint-python.sh	…
lint-qt.sh	test: Add lint to prevent SIGNAL/SLOT connect style	6 years ago
lint-shell-locale.sh	use export LC_ALL=C.UTF-8	6 years ago
lint-shell.sh	…
lint-tests.sh	…
lint-whitespace.sh	…

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.