You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Ryan Ofsky 16a6174613 Merge bitcoin/bitcoin#29904: refactor: Use our own implementation of urlDecode ... 992c714451 common: Don't terminate on null character in UrlDecode (Fabian Jahr) 099fa57151 scripted-diff: Modernize name of urlDecode function and param (Fabian Jahr) 8f39aaae41 refactor: Remove hooking code for urlDecode (Fabian Jahr) 650d43ec15 refactor: Replace libevent use in urlDecode with our own code (Fabian Jahr) 46bc6c2aaa test: Add unit tests for urlDecode (Fabian Jahr) Pull request description: Fixes #29654 (as a side-effect) Removing dependencies is a general goal of the project and the xz backdoor has been an additional wake up call recently. Libevent shows many of the same symptoms, few maintainers and slow releases. While libevent can not be removed completely over night we should start removing it’s usage where it's possible, ideally with the end goal to removing it completely. This is a pretty easy win in that direction. The [`evhttp_uridecode` function from libevent](e0a4574ba2/http.c (L3542)) we were using in `urlDecode` could be easily emulated in fewer LOC. This also ports the [applicable test vectors over from libevent](https://github.com/libevent/libevent/blob/master/test/regress_http.c#L3430). ACKs for top commit: achow101: ACK 992c714451 theStack: Code-review ACK 992c714451 maflcko: ACK 992c714451 👈 stickies-v: ACK 992c714451 Tree-SHA512: 78f76ae7ab3b6710eab2aaac20f55eb0da7803e057eaa6220e865f328666a5399ef1a479702aaf630b2f974ad3aa15e2b6adac9c11bc8c3d4be21e8af1667fea		4 days ago
..
rpc	Merge bitcoin/bitcoin#29904: refactor: Use our own implementation of urlDecode	4 days ago
test	Merge bitcoin/bitcoin#29130: wallet: Add `createwalletdescriptor` and `gethdkeys` RPCs for adding new automatically generated descriptors	1 month ago
bdb.cpp	wallet: bdb batch 'ErasePrefix', do not create txn internally	3 months ago
bdb.h	wallet: bdb: include bdb header from our implementation files only	10 months ago
coincontrol.cpp	wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction	5 months ago
coincontrol.h	wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction	5 months ago
coinselection.cpp	opt: Skip over barren combinations of tiny UTXOs	3 months ago
coinselection.h	coinselection: Track whether CG completed	3 months ago
context.cpp	…
context.h	interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes	6 months ago
crypter.cpp	refactor: Remove unused C-style casts	9 months ago
crypter.h	…
db.cpp	refactor: Fix bugprone-string-constructor warning	6 months ago
db.h	wallet: remove unused 'accept_no_keys' arg from decryption process	3 months ago
dump.cpp	wallettool: Don't create CWallet when dumping DB	4 months ago
dump.h	wallettool: Don't create CWallet when dumping DB	4 months ago
external_signer_scriptpubkeyman.cpp	wallet: return and display signer error	2 weeks ago
external_signer_scriptpubkeyman.h	wallet: return and display signer error	2 weeks ago
feebumper.cpp	test: wallet, fix change position out of range error	5 months ago
feebumper.h	rpc: bumpfee, improve doc for 'reduce_output' arg	7 months ago
fees.cpp	…
fees.h	…
init.cpp	scripted-diff: Fix bitcoin_config_h includes	3 months ago
interfaces.cpp	Merge bitcoin/bitcoin#24313: Improve display address handling for external signer	6 days ago
load.cpp	interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes	6 months ago
load.h	interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes	6 months ago
receive.cpp	[clang-tidy] Enable the misc-no-recursion check	3 weeks ago
receive.h	…
salvage.cpp	tidy: modernize-use-emplace	7 months ago
salvage.h	…
scriptpubkeyman.cpp	[clang-tidy] Enable the misc-no-recursion check	3 weeks ago
scriptpubkeyman.h	wallet: return and display signer error	2 weeks ago
spend.cpp	Merge bitcoin/bitcoin#27877: wallet: Add CoinGrinder coin selection algorithm	3 months ago
spend.h	refactor: pass CRecipient to FundTransaction	3 months ago
sqlite.cpp	Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup	2 months ago
sqlite.h	sqlite: Ensure that only one SQLiteBatch is writing to db at a time	3 months ago
transaction.cpp	scripted-diff: wallet: s/TxStateConflicted/TxStateBlockConflicted	2 months ago
transaction.h	wallet: track mempool conflicts	1 month ago
types.h	…
wallet.cpp	wallet: return and display signer error	2 weeks ago
wallet.h	wallet: return and display signer error	2 weeks ago
walletdb.cpp	Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup	2 months ago
walletdb.h	wallet: db, introduce 'RunWithinTxn()' helper function	3 months ago
wallettool.cpp	wallettool: Don't create CWallet when dumping DB	4 months ago
wallettool.h	…
walletutil.cpp	wallet, descspkm: Refactor wallet descriptor generation to standalone func	1 month ago
walletutil.h	wallet, descspkm: Refactor wallet descriptor generation to standalone func	1 month ago