You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Ryan Ofsky 16a6174613 Merge bitcoin/bitcoin#29904: refactor: Use our own implementation of urlDecode ... 992c714451 common: Don't terminate on null character in UrlDecode (Fabian Jahr) 099fa57151 scripted-diff: Modernize name of urlDecode function and param (Fabian Jahr) 8f39aaae41 refactor: Remove hooking code for urlDecode (Fabian Jahr) 650d43ec15 refactor: Replace libevent use in urlDecode with our own code (Fabian Jahr) 46bc6c2aaa test: Add unit tests for urlDecode (Fabian Jahr) Pull request description: Fixes #29654 (as a side-effect) Removing dependencies is a general goal of the project and the xz backdoor has been an additional wake up call recently. Libevent shows many of the same symptoms, few maintainers and slow releases. While libevent can not be removed completely over night we should start removing it’s usage where it's possible, ideally with the end goal to removing it completely. This is a pretty easy win in that direction. The [`evhttp_uridecode` function from libevent](e0a4574ba2/http.c (L3542)) we were using in `urlDecode` could be easily emulated in fewer LOC. This also ports the [applicable test vectors over from libevent](https://github.com/libevent/libevent/blob/master/test/regress_http.c#L3430). ACKs for top commit: achow101: ACK 992c714451 theStack: Code-review ACK 992c714451 maflcko: ACK 992c714451 👈 stickies-v: ACK 992c714451 Tree-SHA512: 78f76ae7ab3b6710eab2aaac20f55eb0da7803e057eaa6220e865f328666a5399ef1a479702aaf630b2f974ad3aa15e2b6adac9c11bc8c3d4be21e8af1667fea		1 week ago
..
args.cpp	[init] Create deterministic addrman in tests using -test=addrman	4 months ago
args.h	[init] Add new command line arg for use only in functional tests	4 months ago
bloom.cpp	Use Txid in COutpoint	6 months ago
bloom.h	scripted-diff: Bump copyright headers	2 years ago
config.cpp	scripted-diff: move settings to common namespace	11 months ago
init.cpp	Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found	12 months ago
init.h	Deduplicate bitcoind and bitcoin-qt init code	1 year ago
interfaces.cpp	scripted-diff: Bump copyright headers	1 year ago
run_command.cpp	refactor: Rename `subprocess.hpp` to follow our header name conventions	2 weeks ago
run_command.h	refactor: move run_command from util to common	2 years ago
settings.cpp	init: settings, do not load auto-generated warning msg	3 months ago
settings.h	scripted-diff: move settings to common namespace	11 months ago
system.cpp	scripted-diff: Fix bitcoin_config_h includes	3 months ago
system.h	Merge bitcoin/bitcoin#28486: test, bench: Initialize and terminate use of Winsock properly	5 months ago
url.cpp	common: Don't terminate on null character in UrlDecode	2 weeks ago
url.h	scripted-diff: Modernize name of urlDecode function and param	2 weeks ago