bitcoin

Commit Graph

Author	SHA1	Message	Date
MarcoFalke	fa488f131f	scripted-diff: Bump copyright headers -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-	5 years ago
Sebastian Falbesoner	54be4e71d8	test: check specific reject reasons in feature_csv_activation.py this also fixes a bug that was uncovered with this checks: for the BIP112 version 1 tx tests, certain txs (bip112txs_vary_OP_CSV_v1) have been sent twice due to a typo, leading also to a failure as expected but for the wrong reason	5 years ago
Sebastian Falbesoner	5ffaf883b9	test: eliminiated magic numbers in feature_csv_activation.py	5 years ago
Sebastian Falbesoner	09f706ab8e	test: check for OP_CSV empty stack fail reject reason in feature_csv_activation.py	5 years ago
Sebastian Falbesoner	cbd345a75c	test: test OP_CSV empty stack fail in feature_csv_activation.py With BIP112 activated, the operation OP_CHECKSEQUENCEVERIFY (former OP_NOP3) leads to script interpreter termination with an error if one of the following conditions is true: -> stack is empty -> top item on stack is negative (< 0) -> top item on stack has disable flag unset and at least one of four other conditions is true (contains the core CSV logic) This commits adds the missing empty stack failure test to the functional test by prepending a valid scriptSig with just OP_CHECKSEQUENCEVERIFY. If BIP112 is inactive, the operator just behaves as a NOP (for both tx versions 1 and 2) and the transaction remains valid -- if it is active, the tx is invalid due to an empty stack (for both tx versions 1 and 2, as well).	5 years ago
MarcoFalke	fa45d60646	test: Reduce unneeded whitelist permissions in tests	5 years ago
practicalswift	993e38a4e2	tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such	5 years ago
John Newbery	1c93b9b31c	[Consensus] Bury CSV deployment height Hard code CSV deployment height to 419328 for mainnet.	5 years ago
MarcoFalke	fa4680ed09	scripted-diff: Rename sync_blocks to send_blocks to avoid name collisions and confusion -BEGIN VERIFY SCRIPT- FILE_LIST=$(git grep -l 'def sync_blocks' ./test/functional/*.py) sed -i -e 's/def sync_blocks/def send_blocks/g' $FILE_LIST sed -i -e 's/self.sync_blocks/self.send_blocks/g' $FILE_LIST -END VERIFY SCRIPT-	6 years ago
MarcoFalke	faa7cdf764	scripted-diff: Update copyright in ./test -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./test/ -END VERIFY SCRIPT-	6 years ago
MarcoFalke	fa0e65b772	scripted-diff: test: Remove brackets after assert -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/assert ?$(.+)$(( ))?(#.)?$/assert \1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test) -END VERIFY SCRIPT-	6 years ago
Wladimir J. van der Laan	288ddf4ff5	Merge #14180 : qa: Run all tests even if wallet is not compiled `fac9539836` qa: Run all tests even if wallet is not compiled (MarcoFalke) `faa669cbcd` qa: Premine to deterministic address with -disablewallet (MarcoFalke) Pull request description: Currently the test_runner would exit if the wallet was not compiled into the Bitcoin Core executable. However, a lot of the tests run without the wallet just fine and there is no need to globally require the wallet to run the tests. Tree-SHA512: 63177260aa29126fd20f0be217a82b10b62288ab846f96f1cbcc3bd2c52702437703475d91eae3f8d821a3149fc62b725a4c5b2a7b3657b67ffcbc81532a03bb	6 years ago
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	6 years ago
MarcoFalke	fac3e22b18	qa: Read reject reasons from debug log, not p2p messages	6 years ago
MarcoFalke	cf9ed307e6	qa: blocktools enforce named args for amount	6 years ago
MarcoFalke	f66e1c793e	Merge #13669 : Tests: Cleanup create_transaction implementations `44bbceeef1` [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott) `736f941424` [Tests] Cleanup extra instances of create_transaction (Conor Scott) `157651855f` [Tests] Rename create_tx and move to blocktools.py (Conor Scott) Pull request description: There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other. This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149) 1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey 2. `create_transaction`: Return transaction object spending coinbase tx 2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx I am not committed to any of these function names, so I'll gladly take suggestions on there. Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output. Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c	6 years ago
MarcoFalke	8ac7125d59	Merge #13916 : qa: wait_for_verack by default `fa5587fe71` qa: wait_for_verack by default (MarcoFalke) Pull request description: This removes the need to do so manually every time a connection is added. Tree-SHA512: a46c92cb4df41e30778b42b9fd3dcbd8d2d82aa7503d1213cb1c1165034f648d8caee01c292e2d87d05b0f71696996eef5be8a753f35ab49e5f66b0e3bf29f21	6 years ago
Conor Scott	736f941424	[Tests] Cleanup extra instances of create_transaction	6 years ago
MarcoFalke	fa5587fe71	qa: wait_for_verack by default	6 years ago
DrahtBot	eb7daf4d60	Update copyright headers to 2018	6 years ago
MarcoFalke	fa87da2f17	qa: Avoid start/stop of the network thread mid-test	6 years ago
John Newbery	12982682a6	[tests] Change feature_csv_activation.py to use BitcoinTestFramework	7 years ago
John Newbery	db7ffb9d1b	[tests] Move utility functions in feature_csv_activation.py out of class.	7 years ago
John Newbery	0842edf9ee	[tests] Remove nested loops from feature_csv_activation.py Makes the test a lot clearer.	7 years ago
John Newbery	2e511d5424	[tests] improve logging in feature_csv_activation.py	7 years ago
John Newbery	6f7f5bc002	[tests] fix flake8 nits in feature_csv_activation.py	7 years ago
Andrew Chow	eefff65a4b	scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests -BEGIN VERIFY SCRIPT- sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/.py sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/test_framework/.py -END VERIFY SCRIPT-	7 years ago
Anthony Towns	ca6523d0c8	[tests] Rename feature_* functional tests.	7 years ago

28 Commits (fa98e10d5efcd965ee224ec21c9e79ebb123f055)