3 Commits (f27309f55c4fa2b115525d72abb280757a568709)

Author	SHA1	Message	Date
Russell Yanofsky	318f41fb2c	circular-dependencies: Avoid treating some .h/.cpp files as a unit ... This avoids a bogus circular dependency error in the next commit: interfaces/chain -> interfaces/wallet -> wallet/wallet -> interfaces/chain Which is incorrect, because interfaces/chain.cpp depends only on the interfaces/wallet.h file, not the interfaces/wallet.cpp file, and it is wrong to treat these as a unit. Inside the interfaces directory, .h files contain abstract class definitions and .cpp files contain implementations of those classes, so you don't need to link against .cpp files if you're only using the abstract class definition in the .h file. An alternative fix might be to rename all the cpp files in the interfaces directory like: chain.cpp->chain_impl.cpp, node.cpp->node_impl.cpp. But just getting the linter to treat these files as independent dependencies seemed like it would allow keeping code organization straightforward and avoiding the need to rename things.	6 years ago
practicalswift	634bd97001	Explicitly specify encoding when opening text files in Python code	7 years ago
Pieter Wuille	a7b295e91e	Add circular dependencies script	7 years ago