Sebastian Falbesoner
a00ae31fcc
rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet
...
Co-authored-by: Jon Atack <jon@atack.com>
1 year ago
Jon Atack
7ccdd741fe
test: fix importmulti/importdescriptors assertion
...
as these RPCs have a "warnings" field, not a "warning" one.
2 years ago
Jon Atack
9ea8b3739a
test: createwallet "warning" field deprecation test
2 years ago
Jon Atack
645d7f75ac
rpc: deprecate "warning" field in {create,load,unload,restore}wallet
...
This string field has been replaced in these four RPCs by a "warnings" field
returning a JSON array of strings.
2 years ago
Jon Atack
2f4a926e95
test: add test coverage for "warnings" field in createwallet
...
and clarify the "warning" field behavior.
2 years ago
Hennadii Stepanov
306ccd4927
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
- 2021: f47dda2c58
- 2020: fa0074e2d8
- 2019: aaaaad6ac9
2 years ago
MacroFake
555519d082
test: Remove wallet option from non-wallet tests
...
Review note: The changes are complete, because self.options.descriptors
is set to None in parse_args (test_framework.py).
A value of None implies -disablewallet, see the previous commit.
So if a call to add_wallet_options is missing, it will lead to a test
failure when the wallet is compiled in.
2 years ago
Andrew Chow
786b3a7c44
tests: Do not always create a descriptor wallet in wallet_createwallet
...
The createwallet teswt for some invalid parameters incorrectly always
creates a descriptor wallet. This is unnecessary and also breaks the
test when bdb is not compiled in.
3 years ago
w0xlt
6f29409ad1
test: Add a test that creates a wallet with invalid parameters
...
Invalid parameters must not prevent a new wallet with the same name
from being created with the correct parameters
3 years ago
Andrew Chow
61152183ab
wallet: Add a deprecation warning for newly created legacy wallets
3 years ago
Andrew Chow
8fb57845ee
Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default
3 years ago
MarcoFalke
fac23c2114
scripted-diff: Bump copyright headers
...
The previous diff touched most files in ./test/, so bump the headers to
avoid having to touch them again for a bump later.
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./test/
-END VERIFY SCRIPT-
3 years ago
MarcoFalke
fa0b916971
scripted-diff: Use generate* from TestFramework
...
-BEGIN VERIFY SCRIPT-
sed --regexp-extended -i \
's/((self\.)?(nodes\[[^]]+\]|[a-z_]*(wallet|node)[0-9a-z_]*))\.(generate(|toaddress|block|todescriptor)(\(|, ))/self.\5\1, /g' \
$(git grep -l generate ./test | grep -v 'test_framework/' | grep -v 'feature_rbf')
-END VERIFY SCRIPT-
3 years ago
Fabian Jahr
590bda79e8
scripted-diff: Remove setup_clean_chain if default is not changed
...
-BEGIN VERIFY SCRIPT-
git grep -l "self.setup_clean_chain = False" test/functional/*.py | xargs sed -i "/self.setup_clean_chain = False/d";
-END VERIFY SCRIPT-
4 years ago
Andrew Chow
25bc5dccbf
Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py
...
sethdseed and importmulti are not available for descriptor wallets, so
when doing descriptor wallet tests, use importdescriptors instead.
Also changes some output to match what descriptor wallets will return.
4 years ago
MarcoFalke
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
5 years ago
MarcoFalke
fa72d270ad
test: Bump walletpassphrase timeouts in wallet_createwallet to avoid valgrind timeouts
5 years ago
MarcoFalke
4444edc2e6
ci: Enable all functional tests in valgrind
5 years ago
practicalswift
5ac804a9eb
tests: Use a default of supports_cli=True (instead of supports_cli=False)
5 years ago
Andrew Chow
c5d3787367
Allow createwallet to take empty passwords to make unencrypted wallets
...
Allow createwallet to take the empty string as a password and interpret that
as leaving the wallet unencrypted. Also warn when that happens.
5 years ago
Fabian Jahr
ba1f128d6c
Return error for ignored passphrase through disable private keys option
5 years ago
whythat
7860c98bd5
wallet: do not encrypt wallets with disabled private keys
6 years ago
Andrew Chow
662d1171d9
Add option to create an encrypted wallet
6 years ago
MarcoFalke
faa7cdf764
scripted-diff: Update copyright in ./test
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./test/
-END VERIFY SCRIPT-
6 years ago
MarcoFalke
fa0e65b772
scripted-diff: test: Remove brackets after assert
...
-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/assert ?\((.+)\)(( )*)?(#.*)?$/assert \1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test)
-END VERIFY SCRIPT-
6 years ago
Andrew Chow
9b81fd19ac
Fetch keys from keypool when private keys are disabled
...
When private keys are disabled, still fetch keys from the keypool
if the keypool has keys. Those keys come from importing them and
adding them to the keypool.
6 years ago
Andrew Chow
7687f7873b
[wallet] Support creating a blank wallet
...
A blank wallet is a wallet that has no keys, script or watch only things.
A new wallet flag indicating that it is blank will be set when the wallet
is blank. Once it is no longer blank (a seed has been generated, keys or
scripts imported, etc), the flag will be unset.
6 years ago