bitcoin

Commit Graph

Author	SHA1	Message	Date
Hennadii Stepanov	a0473442d1	scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` -BEGIN VERIFY SCRIPT- sed -i -e 's/\s().main\s()/(__file__).main()/' $(git ls-files test/functional/*.py) sed -i -e 's/def __init__(self)/def __init__(self, test_file)/' test/functional/test_framework/test_framework.py -END VERIFY SCRIPT-	4 months ago
Vasil Dimov	0cfc0cd322	net: fix GetListenPort() to derive the proper port `GetListenPort()` uses a simple logic: "if `-port=P` is given, then we must be listening on `P`, otherwise we must be listening on `8333`". This is however not true if `-bind=` has been provided with `:port` part or if `-whitebind=` has been provided. Thus, extend `GetListenPort()` to return the port from `-bind=` or `-whitebind=`, if any. Fixes https://github.com/bitcoin/bitcoin/issues/20184 (cases 1. 2. 3. 5.)	3 years ago

Author

SHA1

Message

Date

Hennadii Stepanov

a0473442d1

scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()`

-BEGIN VERIFY SCRIPT-
sed -i -e 's/\s*().main\s*()/(__file__).main()/' $(git ls-files test/functional/*.py)
sed -i -e 's/def __init__(self)/def __init__(self, test_file)/' test/functional/test_framework/test_framework.py
-END VERIFY SCRIPT-

Vasil Dimov

0cfc0cd322

net: fix GetListenPort() to derive the proper port

`GetListenPort()` uses a simple logic: "if `-port=P` is given, then we
must be listening on `P`, otherwise we must be listening on `8333`".
This is however not true if `-bind=` has been provided with `:port` part
or if `-whitebind=` has been provided. Thus, extend `GetListenPort()` to
return the port from `-bind=` or `-whitebind=`, if any.

Fixes https://github.com/bitcoin/bitcoin/issues/20184 (cases 1. 2. 3. 5.)

2 Commits (f1bcf3edc5027b501616670db33d8be1f2cb5a11)