bitcoin

Commit Graph

Author	SHA1	Message	Date
Hennadii Stepanov	c236f2e228	build: Drop redundant AC_SUBST macros Variables that are declared with AC_ARG_VAR macro are substituted via AC_SUBST macro. PKG_CHECK_MODULES macro already has AC_ARG_VAR(${PACKAGE}_CFLAGS) and AC_ARG_VAR(${PACKAGE}_LIBS).	3 years ago
fanquake	d6d402bd2b	build: remove x-prefix comparisons Very old shells suffered from bugs which meant that prefixing variables with an "x" to ensure that the lefthand side of a comparison always started with an alphanumeric character was needed. Modern shells don't suffer from this issue (i.e Bash was fixed in 1996). In any case, we've already got unprefixed checks used in our codebase, i.e https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L292, and have dependencies (in depends) that also use unprefixed comparisons. I think it's time that we can consolidate on not using the x-prefix workaround. At best it's mostly just confusing. More info: https://github.com/koalaman/shellcheck/wiki/SC2268 https://www.vidarholen.net/contents/blog/?p=1035	3 years ago
fanquake	80762dfc45	build: consistently quote arguments in AC_ARG_VAR()	3 years ago
fanquake	747cd17404	build: no-longer fail default configure if BDB isn't available Inline with moving to descriptor (sqlite) wallets by default for 0.23, this adapts the build system so that a default `./configure` invocation no-longer fails if BDB isn't present. Currently, if configure is run with no options, and no BDB is present, we'll fail with: ```bash checking for Berkeley DB C++ headers... no configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support) ``` If descriptor wallets are to be the default, this behaviour no longer makes sense, as a builder should be able to configure and build, to use a wallet, without BDB installed, and without passing additional arguments, i.e `--without-bdb` or `--with-incompatible-bdb`, to configure. With this change, running configure will no-longer fail, and will instead print: ```bash checking for Berkeley DB C++ headers... no configure: WARNING: libdb_cxx headers missing configure: WARNING: Bitcoin Core requires this library for BDB (legacy) wallet support configure: WARNING: Passing --without-bdb will suppress this warning checking for sqlite3 >= 3.7.17... yes checking whether to build wallet with support for sqlite... yes ```	3 years ago
Andrew Chow	99309ab3e9	Allow disabling BDB in configure with --without-bdb	4 years ago
Jon Layton	6aab7649d3	doc: Fix whitespace errs in .md files, bitcoin.conf, Info.plist.in, and find_bdb48.m4	5 years ago
Randolf Richardson	336685e17e	[build] Add db4_cxx to bitcoin_find_bdb48.m4 Added "db4_cxx" as this is the name used in NetBSD for the Berkeley DB library. Without this additional base filename alternative, the "configure" script will fail to find this library and compilation will not succeed.	7 years ago
Patrick Strateman	1cc251f50f	Explicitly search for bdb5.3. Some systems do not symlink the major version to the minor version.	7 years ago
Wladimir J. van der Laan	8713de83a0	build: Add options to override BDB cflags/libs Add environment settings to specify the CFLAGS and LIBS to be used for BerkeleyDB directly. These will completely by-pass autodetection in the same way as other similar flags. ``` BDB_CFLAGS C compiler flags for BerkeleyDB, bypasses autodetection BDB_LIBS Linker flags for BerkeleyDB, bypasses autodetection ``` Implements #3921.	8 years ago
Luke Dashjr	0c4e6ce88f	Add MIT license to build-aux/m4 scripts	8 years ago
Luke Dashjr	d5f46832de	Unify package name to as few places as possible without major changes	9 years ago
Luke Dashjr	faf0af49f5	Suggest --disable-wallet when libdb_cxx headers are missing	10 years ago
randy-waterhouse	e2a98d270d	Update obsolete AC macros.	10 years ago
randy-waterhouse	52a5f90360	Create the common location for all m4 autotool build scripts, build-aux/m4. Update .gitignore.	10 years ago

14 Commits (ee589d4466bb0548a6f2215afe8abd0735768dab)