8 Commits (e7d66509dc393400079eb885a497dd4e968eade6)

Author	SHA1	Message	Date
willcl-ark	4077e43bf6	test: fix usdt undeclared function errors on mantis ... Recently usage of undeclared functions became an error rather than a warning, in C2x. https://reviews.llvm.org/D122983?id=420290 This change has migrated into the build tools of Ubuntu 23.10 which now causes the USDT tests to fail to compile, see https://github.com/bitcoin/bitcoin/issues/28600 Fix this by setting `-Wno-error=implicit-function-declaration` for the tracing programs.	1 year ago
stickies-v	bc43270450	test: refactor: remove unnecessary nonlocal ... Since we're only mutating, and not reassigning, we don't need to declare `events` as `nonlocal`.	1 year ago
stickies-v	afc0224cdb	test: refactor: remove unnecessary blocks_checked counter ... Since we already store all the blocks in `events`, keeping an additional counter is redundant.	1 year ago
virtu	61f4b9b7ad	Manage exceptions in bcc callback functions ... Exceptions are not propagated in ctype callback functions used by bcc. This means an AssertionError exception raised by check_equal() to signal a failed assertion is not getting caught and properly logged. Instead, the error is logged to stdout and execution of the handler stops. The current workaround to check whether all check_equal() assertions in a callback succeeded is to increment a success counter after the assertions (which only gets incremented if none exception is raised and stops execution). Then, outside the callback, the success counter can be used to check whether a callback executed successfully. One issue with the described workaround is that when an exception occurs, there is no way of telling which of the check_equal() statements caused the exception; moreover, there is no way of inspecting how the pieces of data that got compared in check_equal() differed (often a crucial clue when debugging what went wrong). Two fixes to this problem come to mind. The first involves having the callback function make event data accessible outside the callback and inspecting the event using check_equal() outside the callback. This solution still requires a counter in the callback to tell whether a callback was actually executed or if instead the call to perf_buffer_poll() timed out. The second fix entails wrapping all relevant check_equal() statements inside callback functions into try-catch blocks and manually logging AssertionErrors. While not as elegant in terms of design, this approach can be more pragmatic for more complex tests (e.g., ones involving multiple events, events of different types, or the order of events). The solution proposed here is to select the most pragmatic fix on a case-by-case basis: Tests in interface_usdt_net.py, interface_usdt_mempool.py and interface_usdt_validation.py have been refactored to use the first approach, while the second approach was chosen for interface_usdt_utxocache.py (partly to provide a reference for the second approach, but mainly because the utxocache tests are the most intricate tests, and refactoring them to use the first approach would negatively impact their readability). Lastly, interface_usdt_coinselection.py was kept unchanged because it does not use check_equal() statements inside callback functions.	1 year ago
Jon Atack	459cb637ac	script, test: fix python linter E275 errors with flake8 5.0.4	2 years ago
0xb10c	0532aa7444	test: don't rely on usdt block_conn event order ... Relying on block_connected event order in the USDT interface tests turned out to be brittle. Fixes https://github.com/bitcoin/bitcoin/issues/25793 Fixes https://github.com/bitcoin/bitcoin/issues/25764	2 years ago
0xb10c	220a5a2841	test: hook into PID in tracing tests ... This makes sure to NOT hook into other bitcoind binaries run in paralell in the test framework. We only want to trace the intended binary. In interface_usdt_utxocache.py: While testing the utxocache flush with pruning, bitcoind is restarted and we need to hook into the new PID again.	2 years ago
0xb10c	76c60d7b31	test: validation:block_connected tracepoint test ... This adds a test for the validation:block_connected tracepoint.	3 years ago