42 Commits (e278f12ca71c2d11916352b91594b068183b605e)

Author	SHA1	Message	Date
Matt Corallo	aece8a4637	(finally) remove getinfo in favor of more module-specific infos	7 years ago
João Barbosa	62ecce75e4	[doc] Add RPC response notes	7 years ago
practicalswift	f1708ef89a	Add recommendation: By default, declare single-argument constructors `explicit`	7 years ago
Wladimir J. van der Laan	7ed57d3d7c	Merge #11050: Avoid treating null RPC arguments different from missing arguments ... 745d2e3 Clean up getbalance RPC parameter handling (Russell Yanofsky) fd5d71e Update developer notes after params.size() cleanup (Russell Yanofsky) e067673 Avoid treating null RPC arguments different from missing arguments (Russell Yanofsky) e666efc Get rid of redundant RPC params.size() checks (Russell Yanofsky) Pull request description: This is a followup to #10783. - The first commit doesn't change behavior at all, just simplifies code. - The second commit just changes RPC methods to treat null arguments the same as missing arguments instead of throwing type errors. - The third commit updates developer notes after the cleanup. - The forth commit does some additional code cleanup in `getbalance`. Followup changes that should happen in future PRs: - [ ] Replace uses of `.isTrue()` with calls to `.get_bool()` so numbers, objects, and strings cause type errors instead of being interpreted as false. https://github.com/bitcoin/bitcoin/pull/11050#discussion_r133850525 - [ ] Add braces around if statements. https://github.com/bitcoin/bitcoin/pull/11050#discussion_r133851133 - [ ] Maybe improve UniValue type error exceptions and eliminate RPCTypeCheck and RPCTypeCheckArgument functions. https://github.com/bitcoin/bitcoin/pull/11050#discussion_r133829303 Tree-SHA512: e72f696011d20acc0778e996659e41f9426bffce387b29ff63bf59ad1163d5146761e4445b2b9b9e069a80596a57c7f4402b75a15d5d20f69f775ae558cf67e9	7 years ago
practicalswift	bea8e9e66e	Document the preference of nullptr over NULL or (void*)0	7 years ago
practicalswift	d1e6f91f85	Prefer compile-time checking over run-time checking	7 years ago
MarcoFalke	d7be7b39fa	Merge #10705: Trivial: spelling fixes ... f42fc1d50 doc: spelling fixes (klemens) Pull request description: patch contains some spelling fixes ( just in comments ) as found by a bot ( http://www.misfix.org, https://github.com/ka7/misspell_fixer ). Tree-SHA512: ba6046cfcd81b0783420daae7d776be92dd7b85a593e212f8f1b4403aca9b1b6af12cef7080d4ea5ed4a14952fd25e4300109a59c414e08f5395cdb9947bb750	7 years ago
klemens	f42fc1d508	doc: spelling fixes	7 years ago
Russell Yanofsky	fd5d71ec4b	Update developer notes after params.size() cleanup	7 years ago
Wladimir J. van der Laan	dac37823d4	doc: Correct AmountFromValue/ValueFromAmount names	7 years ago
Marko Bencun	4a7a4ff1f1	developer-notes: add reference to snake_case and PascalCase ... CamelCase is ambiguous as it refers to both lowerCamelCase and UpperCamelCase, whereas PascalCase is only UpperCamelCase.	7 years ago
Wladimir J. van der Laan	f3f1e2e7d3	Merge #9544: [trivial] Add end of namespace comments. Improve consistency. ... 5a9b508 [trivial] Add end of namespace comments (practicalswift) Tree-SHA512: 92b0fcae4d1d3f4da9e97569ae84ef2d6e09625a5815cd0e5f0eb6dd2ecba9852fa85c184c5ae9de5117050330ce995e9867b451fa8cd5512169025990541a2b	7 years ago
Dimitris Tsapakidis	0a5a6b90bc	Fixed multiple typos ... A few "a->an" and "an->a". "Shows, if the supplied default SOCKS5 proxy" -> "Shows if the supplied default SOCKS5 proxy". Change made on 3 occurrences. "without fully understanding the ramification of a command" -> "without fully understanding the ramifications of a command". Removed duplicate words such as "the the".	8 years ago
Pieter Wuille	a090d1c1c9	Header include guideline	8 years ago
practicalswift	5a9b508279	[trivial] Add end of namespace comments	8 years ago
Pieter Wuille	47d8441466	Update style guide	8 years ago
Pavel Janík	f203ecc621	Shadowing is not enabled by default, update doc accordingly.	8 years ago
Wladimir J. van der Laan	c26655ed3f	doc: Add RPC interface guidelines	8 years ago
John Newbery	c28ee91db0	Rename rpc-tests directory to functional	8 years ago
John Newbery	00902c48cd	Rename qa directory to test	8 years ago
Koki Takahashi	36164faa33	Fix typo and spelling inconsistency in CONTRIBUTING.md ... Fix spellings of GitHub Remove unnecessary changes Fix GitHub spelling on doc/translation_process.md	8 years ago
MarcoFalke	fa5137c11d	[doc] Remove unused clang format dev script ... Also, update the clang format file to reflect the current coding style mentioned in the developer notes.	8 years ago
Pieter Wuille	74994c6577	Improve style w.r.t. if	8 years ago
Gregory Maxwell	08ed8c1d07	Developer docs about existing subtrees. ... Add some notes about the workflow for changes to code that exists in subtrees.	8 years ago
Pavel Janík	359bac7cff	Add notes about variable names and shadowing	8 years ago
fanquake	ab53207b9c	[trivial][doc] Mention ++i as preferred to i++ in dev notes	8 years ago
Wladimir J. van der Laan	67db011e12	Merge #8177: developer notes: updates for C++11 ... 654a211 developer notes: updates for C++11 (Kaz Wesley)	9 years ago
Kaz Wesley	654a211622	developer notes: updates for C++11 ... - boost::scoped_ptr is obsolete - std::vector::data replaces begin_ptr / end_ptr	9 years ago
Wladimir J. van der Laan	f7b1bfc9a3	Merge #8178: Add git and github tips and tricks to developer notes ... 3144449 Add git and github tips and tricks to developer notes (Pieter Wuille)	9 years ago
Pieter Wuille	31444491f2	Add git and github tips and tricks to developer notes	9 years ago
Wladimir J. van der Laan	e012f3cea0	util: Add ParseUInt32 and ParseUInt64 ... Add error and range-checking parsers for unsigned 32 and 64 bit numbers. The 32-bit variant is required for parsing sequence numbers from the command line in `bitcoin-tx` (see #8164 for discussion). I've thrown in the 64-bit variant as a bonus, as I'm sure it will be needed at some point. Also adds tests, and updates `developer-notes.md`.	9 years ago
MarcoFalke	fadd048592	[doc] Link to clang-format in the developer notes	9 years ago
MarcoFalke	fada0c422c	[doc] Fix doxygen comments for members	9 years ago
MarcoFalke	fad3035e8d	[doc] Minor markdown fixes	9 years ago
Wladimir J. van der Laan	b8c06ef409	doc: Add non-style-related development guidelines ... I've collected these over time, mostly adding notes after troubleshooting obscure bugs. As I hope to get the community more involved in the whole process, I think it is useful to add to the developer-notes.	9 years ago
Wladimir J. van der Laan	dca7bd3152	doc: Add developer notes about gitignore ... - Add developer notes about `.gitignore.` - Remove qt creator specific files from gitignore, to be consistent.	9 years ago
Mitchell Cash	99963b938f	Correct spelling mistakes in doc folder ... - OSX —> OS X - XCode —> Xcode - github —> GitHub - homebrew —> Homebrew - gitian —> Gitian - Other miscellaneous obvious spelling fixes and whitespace removal	9 years ago
MarcoFalke	60a8b70585	[doc] trivial: developer-notes.md covers more than just coding standards	9 years ago
BtcDrak	06d92d71a2	Add CONTRIBUTING.md	9 years ago
lpescher	f60bb5ee6d	Update documentation to match the #4219 change	10 years ago
Corinne Dashjr	7e6d23b171	Bugfix: Grammar fixes	10 years ago
Michael Ford	3bf5f52808	Create developer-notes.md ... Moves coding guidelines and development tips/tricks into a single file. Also adds a section explaining pull request terminology.	10 years ago