5 Commits (e1f8dce9939a3754555ecd3017f7160a0328c1e6)

Author	SHA1	Message	Date
Wladimir J. van der Laan	5779dc4f76	Merge #13041: build: Add linter checking for accidental introduction of locale dependence ... 698cfd0811 docs: Mention lint-locale-dependence.sh in developer-notes.md (practicalswift) 0a4ea2f458 build: Add linter for checking accidental locale dependence (practicalswift) Pull request description: This linter will check for code accidentally introducing locale dependencies. Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. We should avoid using locale dependent functions if possible. Context: https://github.com/bitcoin/bitcoin/pull/12881#issuecomment-378564722 Example output: ``` $ contrib/devtools/lint-locale-dependence.sh The locale dependent function tolower(...) appears to be used: src/init.cpp: if (s[0] == '0' && std::tolower(s[1]) == 'x') { Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale dependent functions if possible. Advice not applicable in this specific case? Add an exception by updating the ignore list in contrib/devtools/lint-locale-dependence.sh ``` **Note to reviewers:** What is the most appropriate `LOCALE_DEPENDENT_FUNCTIONS` function list? What should be added or removed? Tree-SHA512: 14e448828804bb02bf59070647e38b52fce120c700c903a4a8472769a2cee5dd529bd3fc182386993cb8720482cf4250b63a0a477db61b941ae4babe5c65025f	7 years ago
Ben Woosley	9d6c9dbb88	lint: Add linter to error on #include <*.cpp> ... Files should depend on one another by interface, not by implementation. This checks for quoted includes as well. With practicalswift	7 years ago
practicalswift	0a4ea2f458	build: Add linter for checking accidental locale dependence	7 years ago
practicalswift	81bbd32a2c	build: Guard against accidental introduction of new Boost dependencies	7 years ago
MarcoFalke	fa3c910bfe	test: Move linters to test/lint, add readme	7 years ago