bitcoin

Commit Graph

Author	SHA1	Message	Date
Ben Woosley	9c5af58d51	Consolidate redundant implementations of ParseHashStr This change: * adds a length check to ParseHashStr, appropriate given its use to populate a 256-bit number from a hex str. * allows the caller to handle the failure, which allows for the more appropriate JSONRPCError on failure in prioritisetransaction rpc	6 years ago
Daniel Kraft	57889e688d	bitcoin-tx: Stricter check for valid integers Just calling atoi to convert strings to integers does not check for valid integers very thoroughly; in particular, it just ignores everything starting from the first non-numeral character. Even a string like "foo" is fine and silently returns 0. This meant that bitcoin-tx would not fail if such a string was passed in various places where an integer is expected (like the locktime or an input/output index); this means that it would, for instance, silently accept a typo and interpret it in an unexpected way. In this change, we use ParseInt64 for parsing strings to integers, which actually verifies that the full string is valid as number. New tests in the bitcoin-util-test cover the new error paths.	6 years ago
practicalswift	d27327c79a	Fix typos	7 years ago
Matt Corallo	28d4542a0a	Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds	7 years ago
John Newbery	19ecd1e2e1	Add tests for bitcoin-tx input checking	8 years ago
John Newbery	21704f6334	Check stderr when testing bitcoin-tx	8 years ago
John Newbery	63d66ba20a	Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py	8 years ago

7 Commits (dbf4f3f86a8fd954cd25d8d70afde781c2fe24ce)