f66e1c793e
Merge #13669 : Tests: Cleanup create_transaction implementations
...
44bbceeef1736f941424157651855fhttps://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60 ), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95 ) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48 ), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108 ), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535 ), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129 ), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220 )) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149 )
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54 ) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
6 years ago
8ac7125d59
Merge #13916 : qa: wait_for_verack by default
...
fa5587fe71
6 years ago
736f941424
[Tests] Cleanup extra instances of create_transaction
6 years ago
fa5587fe71
qa: wait_for_verack by default
6 years ago
eb7daf4d60
Update copyright headers to 2018
6 years ago
fa87da2f17
qa: Avoid start/stop of the network thread mid-test
6 years ago
faac7a2db4
qa: Avoid checking reject code for now
...
The node will often disconnect before sending a reject code. A more
robust solution would be to read from the debug log.
7 years ago
472fe8a2ce
Merge #13069 : docs: Fix typos
...
d8c4998f31
7 years ago
fe16dd8226
net: Add option `-enablebip61` to configure sending of BIP61 notifications
...
This commit adds a boolean option `-enablebip61`, defaulting to `1`, that
can be used to disable the sending of BIP61 `reject` messages. This
functionality has been requested for various reasons:
- security (DoS): reject messages can reveal internal state that can be
used to target certain resources such as the mempool more easily.
- bandwidth: a typical node sends lots of reject messages; this counts
against upstream bandwidth. Also the reject messages tend to be larger
than the message that was rejected.
On the other hand, reject messages can be useful while developing client
software (I found them indispensable while creating bitcoin-submittx),
as well as for our own test cases, so whatever the default becomes on the
long run, IMO the functionality should be retained as option. But that's
a discussion for later.
7 years ago
d8c4998f31
Fix typos
7 years ago
364bae5f7a
qa: Pad scriptPubKeys to get minimum sized txs
7 years ago
fadfbd33ab
qa: Add test for orphan handling
7 years ago
54b8c580b7
[test] Fix nits leftover from 11771
...
Remove unused variable reassignments in p2p_invalid_tx.py and call
send_txs_and_test() with valid transaction.
7 years ago
95e2e9af12
[tests] Change invalidtxrequest to use BitcoinTestFramework
7 years ago
359d067572
[tests] Fix flake8 warnings in invalidtxrequest
7 years ago
61b8f7f273
[tests] Rename p2p_* functional tests.
7 years ago
MarcoFalke