bitcoin

Commit Graph

Author	SHA1	Message	Date
jonatack	0ed9cc5892	doc: clarify -i2pacceptincoming help documentation and also hoist the default setting to a constexpr and remove unused f-string operators in a related functional test.	2 years ago
Vasil Dimov	3914e472f5	test: add a test that -i2pacceptincoming=0 creates a transient session The test is a bit primitive as it checks the Bitcoin Core log and assumes that if it logs that it creates a transient session, then it does that indeed. A more thorough test would be to check that it indeed sends the `SESSION CREATE ... DESTINATION=TRANSIENT` command and that it uses the returned I2P address for connecting, even for repeated connections to the same I2P peer. That would require a mocked SAM server (proxy) implementation in Python.	2 years ago

Author

SHA1

Message

Date

jonatack

0ed9cc5892

doc: clarify -i2pacceptincoming help documentation

and also hoist the default setting to a constexpr and
remove unused f-string operators in a related functional test.

Vasil Dimov

3914e472f5

test: add a test that -i2pacceptincoming=0 creates a transient session

The test is a bit primitive as it checks the Bitcoin Core log and
assumes that if it logs that it creates a transient session, then it
does that indeed.

A more thorough test would be to check that it indeed sends the
`SESSION CREATE ... DESTINATION=TRANSIENT` command and that it uses
the returned I2P address for connecting, even for repeated connections
to the same I2P peer. That would require a mocked SAM server (proxy)
implementation in Python.

2 Commits (ca91c244ef1ba7eac6643d66a5fc56d3a2a8b550)