8 Commits (c53c9831eedaf3b311bb942945268830f9ba3abc)

Author	SHA1	Message	Date
John Newbery	d8c218f9c2	[tests] Functional tests call self.start_node(s) and self.stop_node(s) ... This commit changes the individual test scripts to call the start_node(s) and stop_node(s) methods in BitcoinTestFramework.	8 years ago
MarcoFalke	75171f099e	Merge #10137: Remove unused import. Remove accidental trailing semicolons. ... 73b3721 Remove accidental trailing semicolons (practicalswift) b8d9a86 Remove unused import (practicalswift) Tree-SHA512: 36ac38952f8a10f36d2300519c583ef77703cff761be97470be97cfda2fec9d5b7ac604e454f174cc2601160e5cef3f227021ab5d3a6febc97fcb486d78754d3	8 years ago
John Newbery	c9cc76dcaa	[tests] Remove is_network_split from funtional test cases	8 years ago
John Newbery	2a52ae63bf	Remove duplicate method definitions in NodeConnCB subclasses ... All Node classes in individual test cases subclass from NodeConnCB. Many have duplicate definitions for methods that are defined in the base class. This commit removes those duplicate definitions. This commit removes ~290 lines of duplicate code.	8 years ago
practicalswift	b8d9a86dc3	Remove unused import	8 years ago
John Newbery	6a18bb9a36	[tests] sync_with_ping should assert that ping hasn't timed out ... sync_with_ping currently returns false if the timeout expires, and it is the caller's responsibility to fail the test. However, none of the tests currently assert on sync_with_ping()'s return code. This commit adds an assert to sync_with_ping so the test will fail if the timeout expires. This commit also removes all the duplicate implementations of sync_with_ping() from the individual tests.	8 years ago
John Newbery	159fe88abf	Remove SingleNodeConnCB ... This commit merges the NodeConnCB and SingleNodeConnCB into a single class (called NodeConnCB). The original intent for the NodeConnCB was to be able to have a python 'mininode' connect to multiple running bitcoinds. This has never been used and can be achieved more easily by having multiple NodeConns backed by a common datastore if it is ever needed. The changes in mininode.py are just code moves (and merging the two classes into a single class). The code changes in the individual test cases are changing the subclasses to subclass from NodeConnCB instead of SingleNodeConnCB. There is a lot of duplicate code in the subclasses that can be removed in future commits.	8 years ago
John Newbery	c28ee91db0	Rename rpc-tests directory to functional	8 years ago