8 Commits (bbc901d3a683c92438a6b28dca50b956decc4433)

Author	SHA1	Message	Date
MarcoFalke	28f788e47e	Merge #11121: TestNode tidyups ... 7148b74dc [tests] Functional tests must explicitly set num_nodes (John Newbery) 5448a1471 [tests] don't override __init__() in individual tests (John Newbery) 6cf094a02 [tests] Avoid passing around member variables in test_framework (John Newbery) 36b626867 [tests] TestNode: separate add_node from start_node (John Newbery) be2a2ab6a [tests] fix - use rpc_timeout as rpc timeout (John Newbery) Pull request description: Some additional tidyups after the introduction of TestNode: - commit 1 makes TestNode use the correct rpc timeout. This should have been included in #11077 - commit 2 separates `add_node()` from `start_node()` as originally discussed here: https://github.com/bitcoin/bitcoin/pull/10556#discussion_r121161453 with @kallewoof . The test writer no longer needs to assign to `self.nodes` when starting/stopping nodes. - commit 3 adds a `set_test_params()` method, so individual tests don't need to override `__init__()` and call `super().__init__()` Tree-SHA512: 0adb030623b96675b5c29e2890ce99ccd837ed05f721d0c91b35378c5ac01b6658174aac12f1f77402e1d38b61f39b3c43b4df85c96952565dde1cda05b0db84	7 years ago
John Newbery	5448a1471d	[tests] don't override __init__() in individual tests ... Almost all test scripts currently need to override the __init__() method. When they do that they need to call into super().__init__() as the base class does some generic initialization. This commit makes the base class __init__() call into set_test_params() method. Individual test cases can override set_test_params() to setup their test parameters.	7 years ago
John Newbery	6cf094a022	[tests] Avoid passing around member variables in test_framework	7 years ago
John Newbery	36b6268670	[tests] TestNode: separate add_node from start_node ... Separates the act of creating a TestNode object from starting the node. The test_framework now keeps track of its list of TestNodes, and test writers can call start_node() and stop_node() without having to update the self.nodes list.	7 years ago
practicalswift	2e6080bbf3	Remove unused variables and/or function calls	7 years ago
John Newbery	d8c218f9c2	[tests] Functional tests call self.start_node(s) and self.stop_node(s) ... This commit changes the individual test scripts to call the start_node(s) and stop_node(s) methods in BitcoinTestFramework.	8 years ago
practicalswift	72163d4585	[tests] Remove unused and duplicate imports	8 years ago
John Newbery	c28ee91db0	Rename rpc-tests directory to functional	8 years ago