bitcoin

Commit Graph

Author	SHA1	Message	Date
Matt Corallo	e80259f197	Additionally treat Tx.nVersion as unsigned in joinpsbts This gets its own release note callout, though doesn't appear to violate the BIP as the BIP appears to be underspecified. We probably want to update BIP 174 to mention how version numbers are combined.	5 years ago
Matt Corallo	970de70bdd	Dump transaction version as an unsigned integer in RPC/TxToUniv Consensus-wise we already treat it as an unsigned integer (the only rules around it are in CSV/locktime handling), but changing the underlying data type means touching consensus code for a simple cleanup change, which isn't really worth it. See-also, https://github.com/rust-bitcoin/rust-bitcoin/pull/299	5 years ago

Author

SHA1

Message

Date

Matt Corallo

e80259f197

Additionally treat Tx.nVersion as unsigned in joinpsbts

This gets its own release note callout, though doesn't appear to
violate the BIP as the BIP appears to be underspecified. We
probably want to update BIP 174 to mention how version numbers are
combined.

Matt Corallo

970de70bdd

Dump transaction version as an unsigned integer in RPC/TxToUniv

Consensus-wise we already treat it as an unsigned integer (the
only rules around it are in CSV/locktime handling), but changing
the underlying data type means touching consensus code for a
simple cleanup change, which isn't really worth it.

See-also, https://github.com/rust-bitcoin/rust-bitcoin/pull/299

2 Commits (bbc01a753d40488fa1469c87b31e7a12ddc8b329)