bitcoin

Commit Graph

Author	SHA1	Message	Date
MarcoFalke	f32564f0a7	Merge #16681 : Tests: Use self.chain instead of 'regtest' in all current tests `1abcecc40c` Tests: Use self.chain instead of 'regtest' in almost all current tests (Jorge Timón) Pull request description: Simply avoiding the hardcoded string in more places for consistency. It can also allow for more easily reusing tests for other chains other than regtest. Separated from #8994 . Continues #16509 . It is still not complete (ie to be complete, we need the -chain parameter in #16680 and make whether acceptnonstdtxs is allowed for that chain or not customizable for regtest [or for custom chains like in #8994 ] ). But while being incomplete like #16509 , it's quite simple to review and another step forward IMO. ACKs for top commit: Sjors: re-ACK `1abcecc`. I think it's an improvement even if incomplete and if some PR's might accidentally bring "regtest" back. Subsequent improvements hopefully don't have to touch 16 files. elichai: Code review ACK `1abcecc40c` ryanofsky: Code review ACK `1abcecc40c`. ryanofsky: Code review ACK `1abcecc40c` Tree-SHA512: 5620de6dab235ca8bd8670d6366c7b9f04f0e3ca9c5e7f87765b38e16ed80c17d7d1630c0d5fd7c5526f070830d94dc74cc2096d8ede87dc7180ed20569509ee	5 years ago
practicalswift	993e38a4e2	tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such	5 years ago
Jorge Timón	1abcecc40c	Tests: Use self.chain instead of 'regtest' in almost all current tests	5 years ago
MarcoFalke	fa3b9ee8b2	scripted-diff: test: Replace connect_nodes_bi with connect_nodes -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/connect_nodes_bi\(self.nodes,\s(.),\s/connect_nodes(self.nodes[\1], /g' $(git grep -l connect_nodes_bi) sed -i --regexp-extended -e 's/connect_nodes_bi(,\| )/connect_nodes\1/g' $(git grep -l connect_nodes_bi) -END VERIFY SCRIPT-	5 years ago
MarcoFalke	fa6bf21f5e	scripted-diff: test: Use py3.5 bytes::hex() method -BEGIN VERIFY SCRIPT- sed -i -e "s/def bytes_to_hex_str/def b_2_x/g" $(git grep -l bytes_to_hex_str) export RE_B_0="[^()]" # match no bracket export RE_B_1="${RE_B_0}$${RE_B_0}$${RE_B_0}" # match exactly one () export RE_B_2="${RE_B_0}$${RE_B_1}$${RE_B_0}" # match wrapped (()) export RE_M="(b2x\|bytes_to_hex_str)$((${RE_B_0}\|${RE_B_1}\|${RE_B_2}))$" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l -E '(b2x\|bytes_to_hex_str)') sed -i --regexp-extended -e "/ +bytes_to_hex_str( as b2x)?,/d" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/ +bytes_to_hex_str( as b2x)?,//g" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/, bytes_to_hex_str( as b2x)?//g" $(git grep -l bytes_to_hex_str) export RE_M="(binascii\.)?hexlify$((${RE_B_0}\|${RE_B_1}\|${RE_B_2}))$.decode$${RE_B_0}$" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "/from binascii import hexlify$/d" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "s/(from binascii import) .hexlify/\1 unhexlify/g" $(git grep -l hexlify -- ':(exclude)share') sed -i -e 's/ignore-names "/ignore-names "b_2_x,/g' ./test/lint/lint-python-dead-code.sh -END VERIFY SCRIPT-	6 years ago
Akio Nakamura	1a062b85f0	tests: remove byte.hex() to keep compatibility Use test_framework.util.bytes_to_hex_str() instead of bytes.hex() that new in Python 3.5, to support minimum version of Python(test).	6 years ago
MarcoFalke	eca1273c35	Merge #15383 : [rpc] mining: Omit uninitialized currentblockweight, currentblocktx `fa178a6385` [rpc] mining: Omit uninitialized currentblockweight, currentblocktx (MarcoFalke) Pull request description: Previously we'd report "0", which could be mistaken for a valid number. E.g. the number of transactions is 0 or the block weight is 0, whatever that means. Tree-SHA512: ee94ab203a329e272211b726f4c23edec4b09c650ec363b77fd59ad9264165d73064f78ebb9e11b5c2c543b73c157752410a307655560531c7d5444d203aa0ea	6 years ago
MarcoFalke	fa178a6385	[rpc] mining: Omit uninitialized currentblockweight, currentblocktx	6 years ago
Gregory Sanders	b651ef7e1c	submitheader: more directly test missing prev block header	6 years ago
Gregory Sanders	1e7f741745	remove some magic mining constants in functional tests	6 years ago
John Newbery	0025c9eae4	[mining] segwit option must be set in GBT Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified.	6 years ago
Gregory Sanders	2012d4df23	Add CScriptNum decode python implementation in functional suite	6 years ago
Jon Layton	fa0815c300	rpc: Correctly name arguments	6 years ago
sanket1729	0ca4c8b3c6	Changed functional tests which do not require wallets to run without skipping .Addreses #14216. Changed get_deterministic_priv_key() to a named tuple	6 years ago
MarcoFalke	962c302710	Merge #13983 : rpc: Return more specific reject reason for submitblock `fa6ab8ada1` rpc: Return more specific reject reason for submitblock (MarcoFalke) Pull request description: The second commit in #13439 made the `TODO` in the first commit impossible to solve. The meaning of `fNewBlock` changed from "This is the first time we process this block" to "We are about to write the new valid block". So whenever `fNewBlock` is true, the block was valid. And whenever the `fNewBlock` is false, the block is either valid or invalid. If it was valid and not new, we know it is a `"duplicate"`. In all other cases, the `BIP22ValidationResult()` will return the reason why it is invalid. Tree-SHA512: 4b6edf7a912339c3acb0fccfabbdd6d812a0321fb1639c244c2714e58dc119aa2b8c6bf8f7d61ea609a1b861bbc23f920370fcf989c48452721e259a8ce93d24	6 years ago
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	6 years ago
MarcoFalke	fa782a308d	qa: Use named args in some tests	6 years ago
MarcoFalke	fa6ab8ada1	rpc: Return more specific reject reason for submitblock	6 years ago
MarcoFalke	fa091b0016	qa: Add tests for submitheader	6 years ago
practicalswift	68400d8b96	tests: Use explicit imports	6 years ago
DrahtBot	eb7daf4d60	Update copyright headers to 2018	6 years ago
Anthony Towns	3150b3fea7	[tests] Rename misc functional tests.	7 years ago

22 Commits (a3ad6459b77e9b7156e486a9e4a37dbfdc35e324)