6 Commits (9635760ce85e01dbf21c93cc971515a2c4aead88)

Author	SHA1	Message	Date
MarcoFalke	9635760ce8	Merge bitcoin/bitcoin#22777: net processing: don't request tx relay on feeler connections ... eaf6be0114 [net processing] Do not request transaction relay from feeler connections (John Newbery) 0220b834b1 [test] Add testing for outbound feeler connections (John Newbery) Pull request description: Feelers are short-lived connections used to test the viability of peers. The bitcoind node will periodically open feeler connections to addresses in its addrman, wait for a `version` message from the peer, and then close the connection. Currently, we set `fRelay` to `1` in the `version` message for feeler connections, indicating that we want the peer to relay transactions to us. However, we close the connection immediately on receipt of the `version` message, and so never process any incoming transaction announcements. This PR changes that behaviour to instead set `fRelay` to `0` indicating that we do not wish to receive transaction announcements from the peer. This PR also extends the `addconnection` RPC to allow creating outbound feeler connections from the node to the test framework, and a test to verify that the node sets `fRelay` to `0` in the `version` message to feeler connections. ACKs for top commit: naumenkogs: ACK eaf6be0114 MarcoFalke: review ACK eaf6be0114 🏃 Tree-SHA512: 1c56837dbd0a396fe404a5e39f7459864d15f666664d6b35ad109628b13158e077e417e586bf48946a23bd5cbe63716cb4bf22cdf8781b74dfce6047b87b465a	3 years ago
brunoerg	988024fe37	test: add check_node_connections in util	3 years ago
John Newbery	eaf6be0114	[net processing] Do not request transaction relay from feeler connections ... Add a test to verify that feeler connections do not request transaction relay.	3 years ago
John Newbery	0220b834b1	[test] Add testing for outbound feeler connections ... Extend the addconnection RPC method to allow creating outbound feeler connections. Extend the test framework to accept those feeler connections.	3 years ago
Fabian Jahr	590bda79e8	scripted-diff: Remove setup_clean_chain if default is not changed ... -BEGIN VERIFY SCRIPT- git grep -l "self.setup_clean_chain = False" test/functional/*.py | xargs sed -i "/self.setup_clean_chain = False/d"; -END VERIFY SCRIPT-	4 years ago
Amiti Uttarwar	b4dd2ef800	[test] Test the add_outbound_p2p_connection functionality ... Open max number of full-relay and block-relay-only connections from a functional test with different sorts of behaviors to ensure it behaves as expected.	4 years ago