bitcoin

Commit Graph

Author	SHA1	Message	Date
João Barbosa	defffb3587	trivial: Improve include comment in src/interfaces/wallet.h	7 years ago
Wladimir J. van der Laan	c199869408	Merge #12855 : net: Minor accumulated cleanups `2c084a6` net: Minor accumulated cleanups (Thomas Snider) Pull request description: From now-derelict larger changes I had been working on, here are a series of DRY refactors/cleanups. Net loss of 35 lines of code - a small step in the good fight. In particular I think operator!= should only ever be implemented as a negation of operator==. Lower chance for errors, and removes the possibility of divergent behavior. Tree-SHA512: 58bf4b542a4e8e5bc465b508aaa16e9ab51448c3f9bee52cd9db0a64a5c6c5a13e4b4286d0a5aa864934fc58064799f6a88a40a87154fd3a4bd731a72e254393	7 years ago
MarcoFalke	39cf27faf3	Merge #13025 : Dead code removal `1bf3f33b46` node: Removed unused wallet-related methods from the Node interface. (Thomas Snider) `b38200459f` benchmark: Removed bench/perf.cpp (Thomas Snider) Pull request description: Not sure if these should be separate PRs. First is removal of a platform abstraction for getting cycle counters where possible. Since the benchmarking switch to counting number of iterations over a fixed window instead of counting cycles per iteration, these are unused. Second is removal of a few methods from the Node interface that seem vestigial from when the concepts of wallet/node were not as clearly separated. Tree-SHA512: de1460a7d4473ca19db4e2ca845185c63c765d12462c2685044a1f27dedab266cd908bc52235a881a7ad98bc251a4abf4eae523e5f599c169e3511e489f19a0d	7 years ago
Thomas Snider	1bf3f33b46	node: Removed unused wallet-related methods from the Node interface.	7 years ago
Thomas Snider	b38200459f	benchmark: Removed bench/perf.cpp	7 years ago
Pieter Wuille	fb1dfbbec0	Remove unused IsMine overload	7 years ago
Pieter Wuille	952d8213a6	Make CScript -> CScriptID conversion explicit	7 years ago
Ben Woosley	e4d0b44373	Consistently log CValidationState on failure Seems providing at least minimal visibility to the failure is a good practice. The only remaining ignored state is in LoadExternalBlockFile, where logging would likely be spammy.	7 years ago
João Barbosa	3c058fdcc8	wallet: Add HasWallets	7 years ago
João Barbosa	373aee26c3	wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets With these new functions all vpwallets usage are removed and vpwallets is now a static variable (no external linkage).	7 years ago
Jim Posen	b77b6e2345	MOVEONLY: Move logging code from util.{h,cpp} to new files.	7 years ago
João Barbosa	6efd9644cf	refactor: Drop CWalletRef typedef	7 years ago
Ben Woosley	3cc9094d36	scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks To reflect its actual status as a member rather than a global value. g_failed_blocks was previously global: `2862aca40f` -BEGIN VERIFY SCRIPT- sed -i 's/g_failed_blocks/m_failed_blocks/g' src/validation.cpp -END VERIFY SCRIPT-	7 years ago
Wladimir J. van der Laan	615f7c2884	Merge #12985 : Windows: Avoid launching as admin when NSIS installer ends. `7d8a8cc` Avoid launching as admin when NSIS installer ends. (JeremyRand) Pull request description: The Bitcoin Core NSIS script runs with elevated privileges. Unfortunately, this means that it launches Bitcoin Core itself with elevated privileges when the user chooses to launch Bitcoin Core at the end of the installation procedure. This PR works around the issue by having `explorer.exe` launch Bitcoin Core. Seems to be a similar approach to what http://nsis.sourceforge.net/ShellExecAsUser_plug-in does, but without a plugin. I've tested this with Sysinternals Process Explorer on Windows 10 32-bit. I wouldn't expect any differences in behavior on other Windows releases, but if anyone would like to test on other Windows releases, feel free. h/t to "UK" at https://mdb-blog.blogspot.se/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1410158039989#c2463780017054126736 for the sample code. Fixes #7990. Tree-SHA512: f40d6b6e5bb72952dcfbf223b68bfeb9a03bd5638f41b1700f4651f6452ce3fe7468129f6652c4f546210a5fd2521b2574c4b6068c5aea01ed2d719a8a838cd8	7 years ago
Wladimir J. van der Laan	0d12570a80	Merge #13007 : test: Fix dangling wallet pointer in vpwallets `d41a420` test: Fix dangling wallet pointer in vpwallets (João Barbosa) Pull request description: Tree-SHA512: 83e4ec571f1675b3dab6f7606f29d6fae495d998b4e5794ff14315943783d4518cfa66eba4113293e349eb74aa22a024b21272fdb29c212477edb4c09aec9fa7	7 years ago
Wladimir J. van der Laan	8fd62437c6	Merge #12715 : depends: Add 'make clean' rule `aff16fd` depends: Add 'make clean' and 'make clean-all' rules (Henrik Jonsson) Pull request description: It's useful to have a standard way to clean up the work done by the depends system when testing changes to it. Tree-SHA512: d56686ca810c2531d852049420f242178d124d45a2508feeac0acf80408e8a95fc9915fb777ff0cbc4edc496990f5fdecf699c87d7986164c74b8fbf418ebf49	7 years ago
mryandao	7de1de7da4	Add new fee structure with all sub-fields denominated in BTC	7 years ago
MarcoFalke	fa3bb183ad	bench: Amend mempool_eviction test for witness txs	7 years ago
MarcoFalke	962d223e5c	bench: Move constructors out of mempool_eviction hot loop	7 years ago
James O'Beirne	18326ae2a7	[doc] Add comments for chainparams.h, validation.cpp	7 years ago
John Newbery	cead28bbec	[docs] Add release notes for deprecated 'account' API	7 years ago
John Newbery	72c9575f7b	[wallet] [tests] Add tests for accounts/labels APIs	7 years ago
Jonas Schnelli	3a8a4dc4a1	Merge #12791 : Expose a transaction's weight via RPC `9e50c337c` Note new weight field in release-notes. (Matt Corallo) `d0d9112b7` Test new weight field in p2p_segwit (Matt Corallo) `2874709a9` Expose a transaction's weight via RPC (Matt Corallo) Pull request description: This seems like an obvious oversight. Tree-SHA512: defd047de34fb06a31f589e1a4eef68fcae85095cc67b7c8fb434237bb40300d7f3f97e852d3e7226330e26b96943846b7baf6da0cfc79db8d56e9c1f7848ad9	7 years ago
João Barbosa	d41a420562	test: Fix dangling wallet pointer in vpwallets	7 years ago
MarcoFalke	6b46288a08	Merge #12949 : tests: Avoid copies of CTransaction `fae58eca93` tests: Avoid copies of CTransaction (MarcoFalke) Pull request description: Avoid the copy (or move) constructor of `CTransaction` in test code, whereever a simple reference can be used instead. Tree-SHA512: 8ef2077a277d6182996f4671722fdc01a90909ae7431c1e52604aab8ed028910615028caf9b4cb07a9b15fdc04939dea2209cc3189dde7d38271256d9fe1076c	7 years ago
MarcoFalke	a63b4e3493	Merge #12982 : Fix inconsistent namespace formatting guidelines `cd0e1e91dd` Fix inconsistent namespace formatting guidelines (Russell Yanofsky) Pull request description: Suggested formatting for namespaces in the developer guide is currently inconsistent. This commit updates the developer guide and clang-format configuration to consistently put "namespace" and opening/closing braces on the same line. Example: ```c++ namespace boost { namespace signals2 { class connection; } // namespace signals2 } // namespace boost ``` Currently the [Source code organization](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#source-code-organization) section has an example like the one above, but the [Coding style](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style) section example and description put a newline between the opening "namespace foo" and brace (but oddly no newline between closing namespace and brace). Avoiding newlines before namespace opening braces makes nested declarations less verbose and also avoids asymmetry with closing braces. It's also a common style used in our own and other codebases: * https://google.github.io/styleguide/cppguide.html#Namespaces * https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes * https://llvm.org/docs/CodingStandards.html#namespace-indentation Tree-SHA512: 507259478e1a7f6f96db386dd04eb25aa04294f533503fdd82368cf809c3ceaa20204b2cb6ae65322eb27446e5934c1aa1ccb6240ead12aa06b314af76f68139	7 years ago
John Newbery	109e05dcd1	[wallet] [rpc] Deprecate wallet 'account' API This commit finalizes the deprecation of the wallet 'accounts' API by removing all account arguments and return values. RPC behaviour is slightly different if the 'accounts' or 'labels' API is being used. Those behaviour changes are fully documented in the RPC help text.	7 years ago
John Newbery	3576ab1261	[wallet] [rpc] Deprecate account RPC methods All account RPC methods are now deprecated and can only be called if bitcoind has been started with the -deprecatedrpc=accounts switch. Affected RPC methods are: - getaccount - getaccountaddress - getaddressesbyaccount - getreceivedbyaccount - listaccouts - listreceivedbyaccount - move - setaccount	7 years ago
Wladimir J. van der Laan	58bbc55212	Merge #13004 : Print to console by default when not run with -daemon `6a3b0d3` Print to console by default when not run with -daemon (Evan Klitzke) Pull request description: Cherry-picked `ef6fa1c38e` from the "up for grabs" PR: "Smarter default behavior for -printtoconsole" (#12689). See previous review in #12689. Tree-SHA512: 8923a89b9c8973286d53e960d3c464b1cd026cd5a5911ba62f9f972c83684417dc4004101815dfe987fc1e1baaec1fdd90748a0866bb5548e974d77b3135d43b	7 years ago
Wladimir J. van der Laan	39e0c65b29	Merge #12988 : Hold cs_main while calling UpdatedBlockTip() signal `d86edd3` Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) Pull request description: Resolves #12978 Tree-SHA512: 2aed09434cd8dbf541ea75462070b73ee87ff31409bede210f6999ffee4a37e32202a289efd37609485d4cbdfe134fe4660a10bfb41e8a8acdba7cd0b61b8780	7 years ago
Wladimir J. van der Laan	434150aef7	Merge #12977 : Refactor g_wallet_init_interface to const reference `6ec78f1` wallet: Refactor g_wallet_init_interface to const reference (João Barbosa) `1936125` wallet: Make WalletInitInterface members const (João Barbosa) Pull request description: Tree-SHA512: c382156a38d4c6beaa6c48f911d7b314542b9500d88724b2b3029dae4491cb1e60e10628f6632d1366818ccf343f494650b3171593b5450149544ba198f49bb5	7 years ago
Jonas Schnelli	3076993048	Merge #12899 : macOS: Prevent Xcode 9.3 build warnings `2eb5036c3` macOS: Prevent Xcode 9.3 build warnings (Akio Nakamura) Pull request description: This PR intends to solve #12867 1. clang (Apple LLVM version 9.1.0 (clang-902.0.39.1)) warns unused argument '-pie' during compilation. This parameter should pass to the linker, so use '-Wl,-pie' style in configure.ac. 2. The other hand, when linking libbitcoinconsensus.la with passing '-Wl,-pie', ld warns that '-pie' being ignored because not link a main executable. So remove it from $libbitcoinconsensus_la_LDFLAGS in src/Makefile.am. - In order to apply this change to Makefile, you need to run autogen.sh and ./configure. - I think no need to add if-clause by target-os because also g++ can recognize/handle '-Wl,-pie'. - I confirmed that the build was successful on macos10.13.4/XCode9.3 and ubuntu 17.10/g++7.2.0 and that warning was not issued. Tree-SHA512: 45b7c3881f3ad92172eb2ff6fa90c4dc70a42037450ea4b6fd87613b10c0aa90ebcffd54e7c50b70ba876b7c2e356825950fbf5a7a4e8e25118688d98d7b6ee0	7 years ago
Evan Klitzke	6a3b0d3d1a	Print to console by default when not run with -daemon Printing to the debug log file can be disabled with -nodebulogfile	7 years ago
MarcoFalke	fadfbd33ab	qa: Add test for orphan handling	7 years ago
Jesse Cohen	d86edd3d30	Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip Ensures that callbacks are invoked in the order in which the chain is updated Resolves #12978	7 years ago
Thomas Snider	2c084a6609	net: Minor accumulated cleanups	7 years ago
MarcoFalke	07825088f9	Merge #12972 : Add python3 script shebang lint `2bff472992` [contrib] convert test-security-check to python3 (John Newbery) `958bf40489` add lint tool to check python3 shebang (practicalswift) Pull request description: base58.py can executed by python3 Tree-SHA512: 30511204feefd4ccd5b4bf698fb88e516633e692dc95d31fe957b1c0c4879de25906355b28a5a0522171887315c8464a611e601ff00540db172d5bd463ee13d9	7 years ago
Wladimir J. van der Laan	4366f61cc9	Merge #11862 : Network specific conf sections `c25321f` Add config changes to release notes (Anthony Towns) `5e3cbe0` [tests] Unit tests for -testnet/-regtest in [test]/[regtest] sections (Anthony Towns) `005ad26` ArgsManager: special handling for -regtest and -testnet (Anthony Towns) `608415d` [tests] Unit tests for network-specific config entries (Anthony Towns) `68797e2` ArgsManager: Warn when ignoring network-specific config setting (Anthony Towns) `d1fc4d9` ArgsManager: limit some options to only apply on mainnet when in default section (Anthony Towns) `8a9817d` [tests] Use regtest section in functional tests configs (Anthony Towns) `30f9407` [tests] Unit tests for config file sections (Anthony Towns) `95eb66d` ArgsManager: support config file sections (Anthony Towns) `4d34fcc` ArgsManager: drop m_negated_args (Anthony Towns) `3673ca3` ArgsManager: keep command line and config file arguments separate (Anthony Towns) Pull request description: The weekly meeting on [2017-12-07](http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-12-07-19.00.log.html) discussed allowing options to bitcoin to have some sensitivity to what network is in use. @theuni suggested having sections in the config file: <cfields> an alternative to that would be sections in a config file. and on the cmdline they'd look like namespaces. so, [testnet] port=5. or -testnet::port=5. This approach is (more or less) supported by `boost::program_options::detail::config_file_iterator` -- when it sees a `[testnet]` section with `port=5`, it will treat that the same as "testnet.port=5". So `[testnet] port=5` (or `testnet.port=5` without the section header) in bitcoin.conf and `-testnet.port=5` on the command line. The other aspect to this question is possibly limiting some options so that there is no possibility of accidental cross-contamination across networks. For example, if you're using a particular wallet.dat on mainnet, you may not want to accidentally use the same wallet on testnet and risk reusing keys. I've set this up so that the `-addnode` and `-wallet` options are `NETWORK_ONLY`, so that if you have a bitcoin.conf: wallet=/secret/wallet.dat upnp=1 and you run `bitcoind -testnet` or `bitcoind -regtest`, then the `wallet=` setting will be ignored, and should behave as if your bitcoin.conf had specified: upnp=1 [main] wallet=/secret/wallet.dat For any `NETWORK_ONLY` options, if you're using `-testnet` or `-regtest`, you'll have to add the prefix to any command line options. This was necessary for `multiwallet.py` for instance. I've left the "default" options as taking precedence over network specific ones, which might be backwards. So if you have: maxmempool=200 [regtest] maxmempool=100 your maxmempool will still be 200 on regtest. The advantage of doing it this way is that if you have `[regtest] maxmempool=100` in bitcoin.conf, and then say `bitcoind -regtest -maxmempool=200`, the same result is probably in line with what you expect... The other thing to note is that I'm using the chain names from `chainparamsbase.cpp` / `ChainNameFromCommandLine`, so the sections are `[main]`, `[test]` and `[regtest]`; not `[mainnet]` or `[testnet]` as might be expected. Thoughts? Ping @MeshCollider @laanwj @jonasschnelli @morcos Tree-SHA512: f00b5eb75f006189987e5c15e154a42b66ee251777768c1e185d764279070fcb7c41947d8794092b912a03d985843c82e5189871416995436a6260520fb7a4db	7 years ago
John Newbery	3db1ba01c7	[tests] Set -deprecatedrpc=accounts in tests Future commits will deprecate the accounts RPC methods, arguments and return objects. Set the -deprecatedrpc=accounts switch now so tests don't break in intermediate commits.	7 years ago
John Newbery	4e671f0353	[tests] Rename rpc_listtransactions.py to wallet_listtransactions.py listtransactions is a wallet RPC. The test name should indicate that this is a wallet test.	7 years ago
John Newbery	a28b907f8a	[wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table Remove duplicate listreceivedby{account,label} methods.	7 years ago
Chun Kuan Lee	67bf2aa68e	qt:Show the entire Window when double clicking on taskbar	7 years ago
MarcoFalke	6a278e0640	Merge #12996 : tests: Remove redundant bytes(…) calls `9db48c5634` tests: Remove redundant bytes² (practicalswift) Pull request description: This is a follow-up to #12993. As @jnewbery noted `bytes()` is idempotent. Tree-SHA512: 0eb25e0c2c46f9abaac30f964c5eb422bece1414c840a717d86794424294cb19d995a6db7c8df2a2f4ec84776b05274a637f2c111738f397051f510e57184752	7 years ago
MarcoFalke	fe8fa22d7a	Merge #12987 : tests/tools: Enable additional Python flake8 rules for automatic linting via Travis `643aad17fa` Enable additional flake8 rules (practicalswift) `f020aca297` Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift) Pull request description: Enabled rules: ``` * E242: tab after ',' * E266: too many leading '#' for block comment * E401: multiple imports on one line * E402: module level import not at top of file * E701: multiple statements on one line (colon) * E901: SyntaxError: invalid syntax * E902: TokenError: EOF in multi-line string * F821: undefined name 'Foo' * W293: blank line contains whitespace * W606: 'async' and 'await' are reserved keywords starting with Python 3.7 ``` Note to reviewers: * In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR. * Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes. Before this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . 5 E266 too many leading '#' for block comment 4 E401 multiple imports on one line 6 E402 module level import not at top of file 5 E701 multiple statements on one line (colon) 1 F812 list comprehension redefines 'n' from line 159 4 F821 undefined name 'ConnectionRefusedError' 28 W293 blank line contains whitespace ``` After this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . $ ``` Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a	7 years ago
Matt Corallo	150b2f0265	Default to defining endian-conversion DECLs in compat w/o config While this isn't a supported build configuration, some build systems need to build without going through our autotools steps, so defaulting to something sane may make it easier to build. Specifically, this fixes the inability to build rust-bitcoinconsensus on some non-x86 platforms. It needs to build without our autotools/configure steps to ensure correct compile args are passed from the rust build system to gcc. Converting the args from the rust build system to gcc would be a lot of unmaintainable work.	7 years ago
MarcoFalke	fad29582c4	[doc] build-windows: Switch to Artful, since Zesty is EOL	7 years ago
practicalswift	9db48c5634	tests: Remove redundant bytes²	7 years ago
practicalswift	643aad17fa	Enable additional flake8 rules	7 years ago
practicalswift	f020aca297	Minor Python cleanups to make flake8 pass with the new rules enabled	7 years ago
Wladimir J. van der Laan	0d6992168c	Merge #12993 : tests: Remove compatibility code not needed now when we're on Python 3 `b95f9a6` tests: Remove compatibility code not needed now when we're on Python 3 (practicalswift) Pull request description: Remove compatibility code not needed now when we're on Python 3. Tree-SHA512: adc6422794ee08ee8d4c69268e74f0d3eb97c7d3c26c9573698c3305572f20d4840cf9f79fd6fbbe367699bbd95533f90fb6d8569b9787f3f9ca20a3f4c75dd7	7 years ago

1 2 3 4 5 ...

17011 Commits (783bb6455e18c91ede19c7fa62566347066c90e2) All Branches Search

17011 Commits (783bb6455e18c91ede19c7fa62566347066c90e2)

All Branches