fanquake
c9ed9927bb
Merge bitcoin/bitcoin#24132 : build: Bump minimum Qt version to 5.11.3
...
956f7322f6
build: Bump minimum Qt version to 5.11.3 (Hennadii Stepanov)
e22d10b936
ci: Switch from bionic to buster (Hennadii Stepanov)
Pull request description:
The current minimum Qt version is 5.9.5 which has been set in bitcoin/bitcoin#21286 .
Distro support:
- centos 7 -- unsupported since bitcoin/bitcoin#23511
- centos 8 -- [5.15.2](http://mirror.centos.org/centos/8/AppStream/x86_64/os/Packages/qt5-qtbase-5.15.2-3.el8.x86_64.rpm )
- buster -- [5.11.3](https://packages.debian.org/buster/libqt5core5a )
- bullseye -- [5.15.2](https://packages.debian.org/bullseye/libqt5core5a )
- _bionic_ -- [5.9.5](https://packages.ubuntu.com/bionic/libqt5core5a )
- focal -- [5.12.8](https://packages.ubuntu.com/focal/libqt5core5a )
As another Ubuntu LTS is coming soon, it seems unreasonable to stick to Qt 5.9 which support [ended](https://www.qt.io/blog/2017/06/07/renewed-qt-support-services ) on 2020-05-31. Anyway, it's still possible to build Bitcoin Core GUI with depends on bionic system.
Bumping the minimum Qt version allows to make code safer and more reliable, e.g.:
- functor-parameter overload of [`QMetaObject::invokeMethod`](https://doc.qt.io/qt-5/qmetaobject.html#invokeMethod-4 )
- fixed https://bugreports.qt.io/browse/QTBUG-10907
An example of the patch using the functor-overload of `QMetaObject::invokeMethod`:
```diff
--- a/src/qt/walletmodel.cpp
+++ b/src/qt/walletmodel.cpp
@@ -349,7 +349,7 @@ bool WalletModel::changePassphrase(const SecureString &oldPass, const SecureStri
static void NotifyUnload(WalletModel* walletModel)
{
qDebug() << "NotifyUnload";
- bool invoked = QMetaObject::invokeMethod(walletModel, "unload");
+ bool invoked = QMetaObject::invokeMethod(walletModel, &WalletModel::unload);
assert(invoked);
}
```
It uses the same new syntax as signal-slot connection with compile-time check. Also see bitcoin/bitcoin#16348 .
This PR is intended to be merged early [after](https://github.com/bitcoin/bitcoin/issues/22969 ) branching `23.x` off.
ACKs for top commit:
MarcoFalke:
cr ACK 956f7322f6
fanquake:
ACK 956f7322f6
Tree-SHA512: 3d652bcdcd990ce785ad412ed70234d4f27743895e535a53ed44b35d4afc3052e066c4c84f417e30bc53d0a3dd9ebed62444c57b7c765cb1e9aa687fbf866877
3 years ago
MarcoFalke
f1ce67f09f
Merge bitcoin/bitcoin#19013 : test: add v0.20.1, v0.21.0 and v22.0 to backwards compatibility test
...
24cec4b5c0
test: Fix intermittent test failure in feature_backwards_compatibility (MarcoFalke)
d8b705f1ca
test: previous releases: add v22.0 (Sjors Provoost)
40849eebd9
test: bump sandbox argument minimum version (Sjors Provoost)
8a57a06a50
test: previous releases: add v0.21.0 (Sjors Provoost)
8cba75f5fd
test: v0.20.1 backwards compatibility (Sjors Provoost)
0e4b695b6a
test: backwards compatibility: misc fixes (Sjors Provoost)
76557cbe4c
test: Remove i686 from test/get_previous_releases.py (MarcoFalke)
Pull request description:
This also simplifies the tests a bit.
ACKs for top commit:
ryanofsky:
Code review ACK 24cec4b5c0
. Only change since last review is rebasing and adding comment and whitelist args.
Tree-SHA512: 85a603ddd70fd8f0180d00fb84eb2ad2f92d6199b7d3f7c1abd660bfba53f869faf40f1a4183a8ce15dbd496ee3132d879c1258651c9d443ece69e5fe328bd26
3 years ago
Hennadii Stepanov
e22d10b936
ci: Switch from bionic to buster
...
This change is a prerequisite for the following bumping Qt minimum
version to 5.11.3. It is required as bionic has Qt 5.9.5.
Effectively, this also changes:
- gcc from 8.4.0 to 8.3.0
- python from 3.6.5 to 3.7.3
3 years ago
Hennadii Stepanov
f47dda2c58
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
* 2020: fa0074e2d8
* 2019: aaaaad6ac9
3 years ago
fanquake
2da97b271b
ci: use GCC 8 when building packages in native_qt5 CI
...
Our minimum required GCC is GCC 8, and this change in required for
changes like #23839 which take advantage of flags introduced in that
version of GCC.
This should have been included as part of
182de7ba10
.
3 years ago
Sjors Provoost
d8b705f1ca
test: previous releases: add v22.0
3 years ago
Sjors Provoost
8a57a06a50
test: previous releases: add v0.21.0
3 years ago
Hennadii Stepanov
9a1ad7bc0d
test: Enable SC2086 shellcheck rule
3 years ago
fanquake
182de7ba10
ci: update minimum compiler requirements for std::filesystem
3 years ago
fanquake
2ef0accefc
remove --enable-glibc-back-compat from CI and docs
3 years ago
MarcoFalke
531c2b7c04
Merge bitcoin/bitcoin#20354 : test: Add feature_taproot.py --previous_release
...
fa80e10d94
test: Add feature_taproot.py --previous_release (MarcoFalke)
85ccffa266
test: move releases download incantation to README (Sjors Provoost)
29d6b1da2a
test: previous releases: add v0.20.1 (Sjors Provoost)
Pull request description:
Disabling the new consensus code at runtime is fine, but potentially fragile and incomplete. Fix that by giving the option to run with a version that has been compiled without any taproot code.
ACKs for top commit:
Sjors:
tACK fa80e10
NelsonGaldeman:
tACK fa80e10d94
Tree-SHA512: 1a1feef823f08c05268759645a8974e1b2d39a024258f5e6acecbe25097aae3fa9302c27262978b40f1aa8e7b525b60c0047199010f2a5d6017dd6434b4066f0
3 years ago
Sjors Provoost
5be90c907e
build: enable external signer by default
3 years ago
windsok
6f6bb3ebc7
test: fix file permissions on various scripts
...
Updates permissions on files to comply with the new test added in the following commit
4 years ago
Sjors Provoost
b0db187e5b
ci: use --enable-external-signer instead of --with-boost-process
...
An earlier version of #16546 used both --with-boost-process and --enable-external-signer, which was simplified to only use the latter. However I forgot to update CI, so the external signer tests were not run.
4 years ago
Sjors Provoost
29d6b1da2a
test: previous releases: add v0.20.1
...
Can be reviewed with --ignore-all-space
4 years ago
fanquake
ccb7b6a976
contrib: run test-symbol check for RISCV
...
Now that we are using Focal for Gitian building (glibc 2.31), we can
user a newer introduced symbol, and include RISCV in this test.
4 years ago
Dan Benjamin
32cbb06676
build: build fuzz tests by default.
...
This fixes issue #19388 . The changes are as follows:
- Add a new flag to configure, --enable-fuzz-binary, which allows building test/fuzz/fuzz regardless of whether we are building to do actual fuzzing
- Set -DPROVIDE_MAIN_FUNCTION whenever --enable-fuzz is no
- Add the following libraries to FUZZ_SUITE_LD_COMMON:
- LIBBITCOIN_WALLET
- SQLLITE_LIBS
- BDB_LIBS
- if necessary, some or all of:
- NATPMP_LIBS
- MINIUPNPC_LIBS
- LIBBITCOIN_ZMQ / ZMQ_LIBS
4 years ago
Hennadii Stepanov
a8d9f275d0
net: Add libnatpmp support
4 years ago
MarcoFalke
faaee810e6
build: Require C++17 compiler
4 years ago
MarcoFalke
faf58ab139
ci: Add --with-libs=no to one ci config
4 years ago
Hennadii Stepanov
0374e821bd
util: Hard code previous release tarball checksums
4 years ago
Sjors Provoost
c17f54ee53
[ci] use boost::process
...
Explictly opt-out on win64, in case the default changes.
4 years ago
MarcoFalke
fa05f44893
ci: Upgrade most ci configs to focal
4 years ago
fanquake
968aaae940
tests: run test-security-check.py in CI
4 years ago
MarcoFalke
faf1c3cc58
test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option
5 years ago
Sjors Provoost
d135c29476
[ci] make list of previous releases to download a setting
...
Co-Authored-By: MarcoFalke <falke.marco@gmail.com>
5 years ago
MarcoFalke
aaaacff107
ci: Merge C++17 build with one of the existing ones
5 years ago
MarcoFalke
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
5 years ago
MarcoFalke
fa7af33b4c
ci: Run unit tests sequential once
5 years ago
Sjors Provoost
8b1460dbd1
[tests] check v0.17.1 and v0.18.1 backwards compatibility
5 years ago
fanquake
9e111db088
test: set a name for CI Docker containers
5 years ago
MarcoFalke
fa8a60bce9
ci: Run non-cross-compile builds natively
5 years ago