7 Commits (6cbe6209646db8914b87bf6edbc18c6031a16f1e)

Author	SHA1	Message	Date
Samuel Dobson	7ea3b85ecf	Merge #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior ... 8925df86c4 doc: update release notes (Jon Atack) 8bb405bbad test: getaddressinfo labels purpose deprecation test (Jon Atack) 60aba1f2f1 rpc: simplify getaddressinfo labels, deprecate previous behavior (Jon Atack) 7851f14ccf rpc: incorporate review feedback from PR 17283 (Jon Atack) Pull request description: This PR builds on #17283 (now merged) and is followed by #17585. It modifies the value returned by rpc getaddressinfo `labels` to an array of label name strings and deprecates the previous behavior of returning an array of JSON hash structures containing label `name` and address `purpose` key/value pairs. before ``` "labels": [ { "name": "DOUBLE SPEND", "purpose": "receive" } ``` after ``` "labels": [ "DOUBLE SPEND" ] ``` The deprecated behavior can be re-enabled by starting bitcoind with `-deprecatedrpc=labelspurpose`. For context, see: - https://github.com/bitcoin/bitcoin/pull/17283#issuecomment-554458001 - http://www.erisian.com.au/bitcoin-core-dev/log-2019-12-13.html#l-425 (lines 425-427) - http://www.erisian.com.au/bitcoin-core-dev/log-2019-11-22.html#l-622 Reviewers: This PR may be tested manually by building, then running bitcoind with and without the `-deprecatedrpc=labelspurpose` flag while verifying the rpc getaddressinfo help text and `labels` output. Next steps: deprecate the rpc getaddressinfo `label` field (EDIT: done in #17585) and add support for multiple labels per address. This PR will unblock those. ACKs for top commit: jnewbery: reACK 8925df8 promag: Code review ACK 8925df86c4. meshcollider: Code review ACK 8925df86c4 Tree-SHA512: c2b717209996da32b6484de7bb8800e7048410f9ce6afdb3e02a6866bd4a8f2c730f905fca27b10b877b91cf407f546e69e8c4feb9cd934325a6c71c166bd438	5 years ago
Jon Atack	60aba1f2f1	rpc: simplify getaddressinfo labels, deprecate previous behavior ... - change the value returned in the RPC getaddressinfo `labels` field to an array of label name strings - deprecate the previous behavior of returning a JSON hash structure containing label `name` and address `purpose` key/value pairs - update the relevant tests	5 years ago
MarcoFalke	aaaaad6ac9	scripted-diff: Bump copyright of files changed in 2019 ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-	5 years ago
Jon Atack	33f5fc32e5	test: add rpc getaddressinfo labels test coverage	5 years ago
Gregory Sanders	f50785ab56	Change default address type to bech32	5 years ago
John Newbery	2d5f1ea2e3	[tests] move wallet util functions to wallet_util.py ... Adds a new wallet_util.py module and moves generic helper functions there: - get_key - get_multisig - test_address	6 years ago
marcoagner	a6b5ec18ff	rpc: creates possibility to preserve labels on importprivkey ... - changes importprivkey behavior to overwrite existent label if one is passed and keep existing ones if no label is passed - tests behavior of importprivkey on existing address labels and different same key destination	6 years ago