5 Commits (5c998a696c7a4ff2a91fe3d8c7177d2b806eb7ac)

Author	SHA1	Message	Date
Jon Atack	c3f203387d	test: use common assert_signing_completed_successfully helper	1 year ago
Jon Atack	647d95aae9	test: add coverage for passing an invalid sighashtype ... in RPCs descriptorprocesspbst, walletprocesspbst, signrawtransactionwithkey, and signrawtransactionwithwallet.	1 year ago
Sebastian Falbesoner	1a572ce7d6	test: refactor: introduce `generate_keypair` helper with WIF support ... In functional tests it is a quite common scenario to generate fresh elliptic curve keypairs, which is currently a bit cumbersome as it involves multiple steps, e.g.: privkey = ECKey() privkey.generate() privkey_wif = bytes_to_wif(privkey.get_bytes()) pubkey = privkey.get_pubkey().get_bytes() Simplify this by providing a new `generate_keypair` helper function that returns the private key either as `ECKey` object or as WIF-string (depending on the boolean `wif` parameter) and the public key as byte-string; these formats are what we mostly need (currently we don't use `ECPubKey` objects from generated keypairs anywhere). With this, most of the affected code blocks following the pattern above can be replaced by one-liners, e.g.: privkey, pubkey = generate_keypair(wif=True) Note that after this commit, the only direct uses of `ECKey` remain in situations where we want to set the private key explicitly, e.g. in MiniWallet (test/functional/test_framework/wallet.py) or the test for the signet miner script (test/functional/tool_signet_miner.py).	1 year ago
ismaelsadeeq	e47ce42f67	refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey ... This commit updates the code by replacing the RPC call used to decode an address and retrieve its corresponding scriptpubkey with the address_to_scriptpubkey function. address_to_scriptpubkey function can now decode all addresses formats, which makes it more efficient to use.	2 years ago
Ayush Sharma	0ee43d13e9	test: refactor rpc_signrawtransaction.py ... rpc_signrawtransaction.py is split into rpc_signrawtransactionwithkey.py and wallet_signrawtransactionwithwallet.py. rpc_signrawtransactionwithkey.py can be run with the wallet disabled.	2 years ago