7 Commits (3bf2b3a37bbd550491d124b77fd7c1b2a7969f66)

Author	SHA1	Message	Date
MarcoFalke	fa739d4bd7	qa: Add wallet_encryption error tests	6 years ago
Wladimir J. van der Laan	f09bc7ec98	Merge #12493: [wallet] Reopen CDBEnv after encryption instead of shutting down ... c1dde3a949 No longer shutdown after encrypting the wallet (Andrew Chow) d7637c5a3f After encrypting the wallet, reload the database environment (Andrew Chow) 5d296ac810 Add function to close all Db's and reload the databae environment (Andrew Chow) a769461d5e Move BerkeleyEnvironment deletion from internal method to callsite (Andrew Chow) Pull request description: This is the replacement for #11678 which implements @ryanofsky's [suggestion](https://github.com/bitcoin/bitcoin/pull/11678#pullrequestreview-76464511). Shutting down the software was to prevent the BDB environment from writing unencrypted private keys to disk in the database log files, as was noted [here](https://bitcointalk.org/index.php?topic=51474.msg616068#msg616068). This PR replaces the shutdown behavior with a CDBEnv flush, close, and reopen which achieves the same effect: everything is cleanly flushed and closed, the log files are removed, and then the environment reopened to continue normal operation. To ensure that no unencrypted private keys are in the log files after encrypting the wallet, I wrote [this script](https://gist.github.com/achow101/7f7143e6c3d3fdc034d3470e72823e9d) to pull private keys from the original wallet file and searches for these keys in the log files (note that you will have to change your file paths to make it work on your own machine). As for concerns about private keys being written to slack space or being kept in memory, these behaviors no longer exist after the original wallet encryption PR and the shutting down solution from 2011. cc @ryanofsky Tree-SHA512: 34b894283b0677a873d06dee46dff8424dec85a2973009ac9b84bcf3d22d05f227c494168c395219d9aee3178e420cf70d4b3eeacc9785aa86b6015d25758e75	6 years ago
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	6 years ago
Andrew Chow	c1dde3a949	No longer shutdown after encrypting the wallet ... Since the database environment is flushed, closed, and reopened during EncryptWallet, there is no need to shut down the software anymore.	6 years ago
DrahtBot	eb7daf4d60	Update copyright headers to 2018	6 years ago
Suhas Daftuar	662d19ff72	[rpcwallet] Clamp walletpassphrase value at 100M seconds ... Larger values seem to trigger a bug on macos+libevent (resulting in the rpc server stopping).	7 years ago
Anthony Towns	90600bc7db	[tests] Rename wallet_* functional tests.	7 years ago