4 Commits (3997ab915451a702eed2153a0727b0a78c0450ac)

Author	SHA1	Message	Date
MarcoFalke	4769942d90	Merge #19624: Warn on unknown rw_settings ... fa48405ef8 Warn on unknown rw_settings (MarcoFalke) Pull request description: Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded. Something similar is already done for the command line and config file. See: * test: Add test for unknown args #16234 (commit fa7dd88b71) ACKs for top commit: ryanofsky: Code review ACK fa48405ef8. Looks good and I could see this being helpful for debugging. Thanks for taking suggestions Tree-SHA512: cec7d88adf84fa0a842f56b26245157736eb50df433db951e622ea07fd145b899822b24cdab1d8b36c066415ce4f0ef09b493fa8a8d691532822a59c573aafa7	4 years ago
Russell Yanofsky	c1585bca8d	test: Get rid of default wallet hacks ... - Get rid of hardcoded wallet "" names and -wallet="" args - Get rid of setup_nodes (-wallet, -nowallet, -disablewallet) argument rewriting Motivation: - Simplify test framework behavior so it's easier to write new tests without having arguments mangled by the framework - Make tests more readable, replacing unexplained "" string literals with default_wallet_name references - Make it trivial to update default wallet name and wallet data filename for sqlite #19077 testing - Stop relying on -wallet arguments to create wallets, so it is easy to change -wallet option in the future to only load existing wallets not create new ones (to avoid accidental wallet creation, and encourage use of wallet encryption and descriptor features)	4 years ago
MarcoFalke	fa48405ef8	Warn on unknown rw_settings	4 years ago
Russell Yanofsky	9c69cfe4c5	Add <datadir>/settings.json persistent settings storage. ... Persistent settings are used in followup PRs #15936 to unify gui settings between bitcoin-qt and bitcoind, and #15937 to add a load_on_startup flag to the loadwallet RPC and maintain a dynamic list of wallets that should be loaded on startup that also can be shared between bitcoind and bitcoin-qt.	4 years ago