bitcoin

Commit Graph

Author	SHA1	Message	Date
merge-script	40c11ac318	Merge bitcoin/bitcoin#30624 : doc: Remove outdated nTx faking comment `fa04511e44` doc: Remove outdated nTx faking comment (MarcoFalke) Pull request description: This problematic `nTx` "faking" was removed in commit `b50554babd`. So fix the wrong comment. Also, address the typo nits from: * https://github.com/bitcoin/bitcoin/pull/29370#discussion_r1531789314 * https://github.com/bitcoin/bitcoin/pull/30598#discussion_r1711982543 ACKs for top commit: fjahr: ACK `fa04511e44` Tree-SHA512: c918f0b9274be9c347a37d6221915688977a858fb8d2146035718bf17df0bd3b51d67ef12b971556851c0f69f46d26f557c35a5461abeb0683b538b9dc48f5b6	3 months ago
merge-script	d00bf4eaf6	Merge bitcoin/bitcoin#30630 : doc: Update ccache website link `fec74a8bcb` doc: Update ccache website link (Hennadii Stepanov) Pull request description: ACKs for top commit: paplorinc: ACK `fec74a8bcb` tdb3: ACK `fec74a8bcb` hodlinator: ACK `fec74a8bcb` Tree-SHA512: 1331b6d37d1bfc124bbce08bb584235c0610671655d7a4a82882aba2aa73c3c741dce013e6ce9baba00a07bc26d4a9c5aa8da4abd38187ffe7b8a101e2366bda	3 months ago
glozow	257a4fda3c	Merge bitcoin/bitcoin#30616 : test: remove `ExtractDestination` false assertion for `ANCHOR` script `a4f2b18573` [test]: remove `ExtractDestination` false assertion for `ANCHOR` script (ismaelsadeeq) Pull request description: This PR fixes #30615 `ExtractDestination` returns `true` when `TxoutType` is `ANCHOR` see https://github.com/bitcoin/bitcoin/issues/30615#issuecomment-2277538703 ACKs for top commit: maflcko: review ACK `a4f2b18573` instagibbs: ACK `a4f2b18573` theStack: utACK `a4f2b18573` BrandonOdiwuor: Code Review ACK `a4f2b18573` glozow: ACK `a4f2b18573` Tree-SHA512: 6120494fe888acf26b252d4aadc01dc256e294ea5e4c954fd9b4694be27dc35cf0e33e3b3bcb012fb4abe1cab0b1d0d515db226fa771e791e0fe7efbcbd8834d	3 months ago
Hennadii Stepanov	fec74a8bcb	doc: Update ccache website link	3 months ago
Fabian Jahr	b0ec8716bf	chainparams: Handle Testnet4 in GetNetworkForMagic	3 months ago
MarcoFalke	fa04511e44	doc: Remove outdated nTx faking comment This was fixed in commit `b50554babd`. Also, address the typo nits from: * https://github.com/bitcoin/bitcoin/pull/29370#discussion_r1531789314 * https://github.com/bitcoin/bitcoin/pull/30598#discussion_r1711982543	3 months ago
Sjors Provoost	1610643c8b	chainparams: add mainnet assumeutxo param at height 840_000	3 months ago
Ava Chow	c2d15d993e	Merge bitcoin/bitcoin#29519 : p2p: For assumeutxo, download snapshot chain before background chain `49d569cb1f` p2p: For assumeutxo, download snapshot chain before background chain (Martin Zumsande) `7a885518d5` p2p: Restrict downloading of blocks for snapshot chain (Martin Zumsande) Pull request description: After loading a snapshot, `pindexLastCommonBlock` is usually already set to some block for existing peers. That means we'd continue syncing the background chain from those peers instead of prioritising the snapshot chain, which defeats the purpose of doing assumeutxo in the first place. Only existing peers are affected by this bug. ACKs for top commit: fjahr: re-ACK `49d569cb1f` achow101: ACK `49d569cb1f` Sjors: tACK `49d569cb1f` Tree-SHA512: 0eaebe1c29a8510d5ced57e14c09b128ccb34b491692815291df68bf12e2a15b52b1e7bf8d9f34808904e7f7bc20f70b0ad0f7e14df93bbdf456bd12cc02a5d2	3 months ago
Ava Chow	9a696397e7	Merge bitcoin/bitcoin#30598 : assumeutxo: Drop block height from metadata `00618e8745` assumeutxo: Drop block height from metadata (Fabian Jahr) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/30514 which has more context and shows how the issue can be reproduced. Since the value in question is removed, there is no test to add to reproduce anything. This is an alternative approach to #30516 with much of the [code being suggested there](https://github.com/bitcoin/bitcoin/pull/30516#discussion_r1689146902). ACKs for top commit: maflcko: re-ACK `00618e8745` 🎌 achow101: ACK `00618e8745` theStack: Code-review ACK `00618e8745` ismaelsadeeq: Re-ACK `00618e8745` mzumsande: ACK `00618e8745` Tree-SHA512: db9575247bae838ad7742a27a216faaf55bb11e022f9afdd05752bb09bbf9614717d0ad64304ff5722a16bf41d8dea888af544e4ae26dcaa528c1add0269a4a8	3 months ago
Ava Chow	6b2dcba076	wallet: List sqlite wallets with empty string name Although it is not explicitly possible to create a default wallet with descriptors, it is possible to migrate a default wallet and have it end up being a default wallet with descriptors. These wallets should be listed by ListDatabases so that it appears in wallet directory listings to avoid user confusion.	3 months ago
Ava Chow	3ddbdd1815	wallet: Ignore .bak files when listing wallet files Migration creates backup files in the wallet directory with .bak as the extension. This pollutes the output of listwalletdir with backup files that most users should not need to care about.	3 months ago
Ava Chow	389cf32aca	Merge bitcoin/bitcoin#30604 : doc, chainparams: 29775 release notes and follow-ups `92c1d7d1f8` validation: Use MAX_TIMEWARP constant as testnet4 timewarp defense delta (Fabian Jahr) `4b2fad502e` doc: Add release notes for 29775 (Fabian Jahr) `f7cc97313b` doc: Align deprecation warnings (Fabian Jahr) `1163b08378` chainparams: Add initial minimum chain work for Testnet4 (Fabian Jahr) Pull request description: This completes follow-ups left open in #29775. - Adds release notes - Addresses the [misalignment](https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1706982102) in deprecation warnings and hints at the intention to remove support for Testnet3. - Adds initial minimum chainwork for Testnet4. - Use the `MAX_TIMEWARP` constant as the timewarp defense delta, equal to `MAX_FUTURE_BLOCK_TIME`. ACKs for top commit: Sjors: ACK `92c1d7d1f8` achow101: ACK `92c1d7d1f8` tdb3: re ACK `92c1d7d1f8` Tree-SHA512: 7ebdac7809f96231f75ca62706af59cd1ed27f713a4c7be5e2ad69fae95832b146b3ea23c712fb03b412da1deda7e8a5dae55bb2bbd2dcfd9f926e85c2a72666	3 months ago
Fabian Jahr	92c1d7d1f8	validation: Use MAX_TIMEWARP constant as testnet4 timewarp defense delta The value is equal to MAX_FUTURE_BLOCK_TIME.	3 months ago
MarcoFalke	fa6fe43207	net: Clarify that m_addr_local is only set once Includes a rename from addrLocal to m_addr_local to match the name of its corresponding Mutex.	3 months ago
ismaelsadeeq	a4f2b18573	[test]: remove `ExtractDestination` false assertion for `ANCHOR` script	3 months ago
merge-script	bacab1380e	Merge bitcoin/bitcoin#30609 : guix: bump time-machine to 7bf1d7aeaffba15c4f680f93ae88fbef25427252 `eca20bead2` guix: bump time-machine to 7bf1d7aeaffba15c4f680f93ae88fbef25427252 (fanquake) Pull request description: Includes: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d428237642e1e4ac8fda4597205ffec89926c0ec. which removes the need to build Python2, and OpenSSL `1.x` (which has historically caused issues) when building for Windows (Python2 (with a dependency on OpenSSL `1.x`) used to be a dependency of NSIS). Linux Kernel Headers `6.1.100` -> `6.1.102` ```bash d079858fb1bc526217ee06f312d97a56c34986440e5f9e108af66eaecacea073 guix-build-eca20bead2da/output/aarch64-linux-gnu/SHA256SUMS.part 2db780ffe39210a3ba113e52362d94840449218ac1747e3a3484606cc36acead guix-build-eca20bead2da/output/aarch64-linux-gnu/bitcoin-eca20bead2da-aarch64-linux-gnu-debug.tar.gz b56b602bd87e73b11a6b68147c52c6dfa53f0ec4bac52ac749765025e7b43bc9 guix-build-eca20bead2da/output/aarch64-linux-gnu/bitcoin-eca20bead2da-aarch64-linux-gnu.tar.gz d56a9a6ac683da2e347d2ea71fab0cd54a126604ac1c9cc4d8fa89f6343ddb52 guix-build-eca20bead2da/output/arm-linux-gnueabihf/SHA256SUMS.part 6555b6d837605b35c5cf72ab4e5728d9205f8481e3e4bc9e1bbe44e09a1aa1a3 guix-build-eca20bead2da/output/arm-linux-gnueabihf/bitcoin-eca20bead2da-arm-linux-gnueabihf-debug.tar.gz d310e9a532d035db238552ad3fa3779b93d062e655f8e477ff029682af4f7cf4 guix-build-eca20bead2da/output/arm-linux-gnueabihf/bitcoin-eca20bead2da-arm-linux-gnueabihf.tar.gz eab39d953890e2d36b92b53e43a711ab615090d5b9030861229386e4a41344d8 guix-build-eca20bead2da/output/arm64-apple-darwin/SHA256SUMS.part 394473362a4d4895431d9250702e9e87f8ccb880a2b723eeb0cfd8eed1635518 guix-build-eca20bead2da/output/arm64-apple-darwin/bitcoin-eca20bead2da-arm64-apple-darwin-unsigned.tar.gz 3e72306a34e69647200fe5b3d5e8da3bc3b75105d3eeb9f5d5b5332de5d8e464 guix-build-eca20bead2da/output/arm64-apple-darwin/bitcoin-eca20bead2da-arm64-apple-darwin-unsigned.zip 1b0515ab24a57706278bde37b88a0dc51188373154876997dcbf61f2c9cf2c65 guix-build-eca20bead2da/output/arm64-apple-darwin/bitcoin-eca20bead2da-arm64-apple-darwin.tar.gz fba7470833ff076c01de5f2ed4a4d697f8a2e06cec49098f89d40e84c4798357 guix-build-eca20bead2da/output/dist-archive/bitcoin-eca20bead2da.tar.gz 935cc2ebec9b595da67bcde22a395060817fdf16b3a31f14e6b2252cb5073640 guix-build-eca20bead2da/output/powerpc64-linux-gnu/SHA256SUMS.part 85ee64aa6d0ab6d3431b7c0af3e26a9bfdb365343ba1b5198e321ae0f6778d33 guix-build-eca20bead2da/output/powerpc64-linux-gnu/bitcoin-eca20bead2da-powerpc64-linux-gnu-debug.tar.gz 52a1a8e8fdb48589cfb00c35001ae8765f6127d472d11ad03c3faa3621e45032 guix-build-eca20bead2da/output/powerpc64-linux-gnu/bitcoin-eca20bead2da-powerpc64-linux-gnu.tar.gz 72ccb2577dd11342dfce124346d359b19d8bc4af12cd445447e0568321dd39b9 guix-build-eca20bead2da/output/riscv64-linux-gnu/SHA256SUMS.part 80a0d80c3adb8e2de27605ed0b2bd7f5442c8316397a53a3e0e840a14587b057 guix-build-eca20bead2da/output/riscv64-linux-gnu/bitcoin-eca20bead2da-riscv64-linux-gnu-debug.tar.gz 62de93f8defc9e561caed1586bee20e208be1d66cdc8bf593f5e09e3c28d03a6 guix-build-eca20bead2da/output/riscv64-linux-gnu/bitcoin-eca20bead2da-riscv64-linux-gnu.tar.gz e5af6b6bb63d88f7797531f855ad0a8fb5bf0e4645a7b2f83516b4cb26bf1da4 guix-build-eca20bead2da/output/x86_64-apple-darwin/SHA256SUMS.part 3743509c6ad5fb3837bd8d420885b49221515e89d1bba12f8816f401879bee7a guix-build-eca20bead2da/output/x86_64-apple-darwin/bitcoin-eca20bead2da-x86_64-apple-darwin-unsigned.tar.gz cc6fb35a57506250790ddea4aaa7888aa9d1db66f8ce3f09c830898f83f2f39f guix-build-eca20bead2da/output/x86_64-apple-darwin/bitcoin-eca20bead2da-x86_64-apple-darwin-unsigned.zip 4b4d2096e87ca10847e5a543ff32f002325c882856523f0fc5d70564009f9244 guix-build-eca20bead2da/output/x86_64-apple-darwin/bitcoin-eca20bead2da-x86_64-apple-darwin.tar.gz 1989106147fc5f77bc27a08886bb2120ff0c49cbe6ea97b9e234752740ec81ad guix-build-eca20bead2da/output/x86_64-linux-gnu/SHA256SUMS.part bdb48a649f9ca026e6bbab28159f716a1ad4b84257588e1a12bf4467e4c7acb6 guix-build-eca20bead2da/output/x86_64-linux-gnu/bitcoin-eca20bead2da-x86_64-linux-gnu-debug.tar.gz aff4717e841508bd6284d846d8c6da7da3622bf54d68a8919e3fd95814beb309 guix-build-eca20bead2da/output/x86_64-linux-gnu/bitcoin-eca20bead2da-x86_64-linux-gnu.tar.gz fdc8346e0b0f03648399b74a0d38d961c985c5ec8128193443be0b7208632f06 guix-build-eca20bead2da/output/x86_64-w64-mingw32/SHA256SUMS.part a50f517e3f2467e5931349315bbe0968e190e8bcdbb024e3a8d4c37333938155 guix-build-eca20bead2da/output/x86_64-w64-mingw32/bitcoin-eca20bead2da-win64-debug.zip 38223484c214a90193f88f8c60743b376ce0c80f9401ec863ccb36a1337c85a2 guix-build-eca20bead2da/output/x86_64-w64-mingw32/bitcoin-eca20bead2da-win64-setup-unsigned.exe 07fca2496b2c59ea928684c4bf4ef163686f8fb11934117c6c37407a3a374363 guix-build-eca20bead2da/output/x86_64-w64-mingw32/bitcoin-eca20bead2da-win64-unsigned.tar.gz 8e71711db17c69000627c44965eb7070fc92788f792ea3d0778a55bdadf36cdb guix-build-eca20bead2da/output/x86_64-w64-mingw32/bitcoin-eca20bead2da-win64.zip ``` ACKs for top commit: TheCharlatan: Nice, ACK `eca20bead2` Tree-SHA512: eb1795dcc82bd975b76631326c72c4456d71be8b8cf509195295021c0581abee6da36b55d7faddb440f953e24996ee70b01b35ae9e945fcbb0799efb2e29b916	3 months ago
merge-script	24ced52744	Merge bitcoin/bitcoin#28687 : C++20 std::views::reverse `2925bd537c` refactor: use c++20 std::views::reverse instead of reverse_iterator.h (stickies-v) Pull request description: C++20 introduces [`std::ranges::views::reverse`](https://en.cppreference.com/w/cpp/ranges/reverse_view), which allows us to drop our own `reverse_iterator.h` implementation and also makes it easier to chain views (even though I think we currently don't use this). ACKs for top commit: achow101: ACK `2925bd537c` maflcko: ACK `2925bd537c` 🎷 Tree-SHA512: 567666ec44af5d1beb7a271836bcc89c4c577abc77f522fcc18bc6d4de516ae9b0df766d0bfa6dd217569e6878331c2aee1d9815620860375e3510dad7fed476	3 months ago
MarcoFalke	fac7b7ff7f	lint: Find function calls in default arguments	3 months ago
Fabian Jahr	4b2fad502e	doc: Add release notes for 29775	3 months ago
Fabian Jahr	f7cc97313b	doc: Align deprecation warnings	3 months ago
Fabian Jahr	00618e8745	assumeutxo: Drop block height from metadata The Snapshot format version is updated to 2 to indicate this change. Co-authored-by: MarcoFalke <*~=`'#}+{/-\|&$^_@721217.xyz>	3 months ago
Lőrinc	204ca67bba	Reduce cache lookups in CCoinsViewCache::FetchCoin Enhanced efficiency and readability of CCoinsViewCache::FetchCoin by replacing separate find() and emplace() calls with a single try_emplace(), reducing map lookups and potential insertions.	3 months ago
fanquake	eca20bead2	guix: bump time-machine to 7bf1d7aeaffba15c4f680f93ae88fbef25427252 Includes: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d428237642e1e4ac8fda4597205ffec89926c0ec. which removes the need to build Python2, and OpenSSL 1.x when building for Windows.	3 months ago
Ava Chow	27a770b34b	Merge bitcoin/bitcoin#28280 : Don't empty dbcache on prune flushes: >30% faster IBD `589db872e1` validation: don't erase coins cache on prune flushes (Andrew Toth) `0e8918755f` Add linked-list test to CCoinsViewCache::SanityCheck (Pieter Wuille) `05cf4e1875` coins: move Sync logic to CoinsViewCacheCursor (Andrew Toth) `7825b8b9ae` coins: pass linked list of flagged entries to BatchWrite (Andrew Toth) `a14edada8a` test: add cache entry linked list tests (Andrew Toth) `24ce37cb86` coins: track flagged cache entries in linked list (Andrew Toth) `58b7ed156d` coins: call ClearFlags in CCoinsCacheEntry destructor (Andrew Toth) `8bd3959fea` refactor: require self and sentinel parameters for AddFlags (Andrew Toth) `75f36d241d` refactor: add CoinsCachePair alias (Andrew Toth) `f08faeade2` refactor: move flags to private uint8_t and rename to m_flags (Andrew Toth) `4e4fb4cbab` refactor: disallow setting flags in CCoinsCacheEntry constructors (Andrew Toth) `8737c0cefa` refactor: encapsulate flags setting with AddFlags and ClearFlags (Andrew Toth) `9715d3bf1e` refactor: encapsulate flags get access for all other checks (Andrew Toth) `df34a94e57` refactor: encapsulate flags access for dirty and fresh checks (Andrew Toth) Pull request description: Since https://github.com/bitcoin/bitcoin/pull/17487 we no longer need to clear the coins cache when syncing to disk. A warm coins cache significantly speeds up block connection, and only needs to be fully flushed when nearing the `dbcache` limit. For frequent pruning flushes there's no need to empty the cache and kill connect block speed. However, simply using `Sync` in place of `Flush` actually slows down a pruned full IBD with a high `dbcache` value. This is because as the cache grows, sync takes longer since every coin in the cache is scanned to check if it's dirty. For frequent prune flushes and a large cache this constant scanning starts to really slow IBD down, and just emptying the cache on every prune becomes faster. To fix this, we can add two pointers to each cache entry and construct a doubly linked list of dirty entries. We can then only iterate through all dirty entries on each `Sync`, and simply clear the pointers after. With this approach a full IBD with `dbcache=16384` and `prune=550` was 32% faster than master. For default `dbcache=450` speedup was ~9%. All benchmarks were run with `stopatheight=800000`. \| \| prune \| dbcache \| time \| max RSS \| speedup \| \|-----------:\|----------:\|------------:\|--------:\|-------------:\|--------------:\| \| master \| 550 \| 16384 \| 8:52:57 \| 2,417,464k \| - \| \| branch \| 550 \| 16384 \| 6:01:00 \| 16,216,736k \| 32% \| \| branch \| 550 \| 450 \| 8:05:08 \| 2,818,072k \| 8.8% \| \| master \| 10000 \| 5000 \| 8:19:59 \| 2,962,752k \| - \| \| branch \| 10000 \| 5000\| 5:56:39 \| 6,179,764k \| 28.8% \| \| master \| 0 \| 16384 \| 4:51:53 \| 14,726,408k \| - \| \| branch \| 0 \| 16384 \| 4:43:11 \| 16,526,348k \| 2.7% \| \| master \| 0 \| 450 \| 7:08:07 \| 3,005,892k \| - \| \| branch \| 0 \| 450 \| 6:57:24 \| 3,013,556k \|2.6%\| While the 2 pointers add memory to each cache entry, it did not slow down IBD. For non-pruned IBD results were similar for this branch and master. When I performed the initial IBD, the full UTXO set could be held in memory when using the max `dbcache` value. For non-pruned IBD with max `dbcache` to tip ended up using 12% more memory, but it was also 2.7% faster somehow. For smaller `dbcache` values the `dbcache` limit is respected so does not consume more memory, and the potentially more frequent flushes were not significant enough to cause any slowdown. For reviewers, the commits in order do the following: First 4 commits encapsulate all accesses to `flags` on cache entries, and then the 5th makes `flags` private. Commits `refactor: add CoinsCachePair alias` to `coins: call ClearFlags in CCoinsCacheEntry destructor` create the linked list head nodes and cache entry self references and pass them into `AddFlags`. Commit `coins: track flagged cache entries in linked list` actually adds the entries into a linked list when they are flagged DIRTY or FRESH and removes them from the linked list when they are destroyed or the flags are cleared manually. However, the linked list is not yet used anywhere. Commit `test: add cache entry linked list tests` adds unit tests for the linked list. Commit `coins: pass linked list of flagged entries to BatchWrite` uses the linked list to iterate through DIRTY entries instead of using the entire coins cache. Commit `validation: don't erase coins cache on prune flushes` uses `Sync` instead of `Flush` for pruning flushes, so the cache is no longer cleared. Inspired by [this comment](https://github.com/bitcoin/bitcoin/pull/15265#issuecomment-457720636). Fixes https://github.com/bitcoin/bitcoin/issues/11315. ACKs for top commit: paplorinc: ACK `589db872e1` sipa: reACK `589db872e1` achow101: ACK `589db872e1` mzumsande: re-ACK `589db872e1` Tree-SHA512: 23b2bc01c83edacb5b39aa60bb0b766de9a74ce17f0c59bf13b97b4328a7b758ad9aff6581c3ca88e2973f7658380651530d497444f48d6e22ea0bfc51cc921d	3 months ago
Sebastian Falbesoner	77ff0ec1f1	contrib: support reading XORed blocks in linearize-data.py script Partly fixes issue #30599.	3 months ago
Fabian Jahr	1163b08378	chainparams: Add initial minimum chain work for Testnet4 This chainwork was observed at height 38487.	3 months ago
sunerok	4c2cc63d84	Revert "depends: Fetch miniupnpc sources from an alternative website" This reverts commit `21b8a14d37`.	3 months ago
glozow	0f68a05c08	Merge bitcoin/bitcoin#30194 : refactor: use recommended type hiding on multi_index types `a3cb309e7c` refactor: use recommended type hiding on multi_index types (Cory Fields) Pull request description: Recommended by boost docs: https://www.boost.org/doc/libs/1_85_0/libs/multi_index/doc/compiler_specifics.html#type_hiding This significantly reduces the size of the symbol name lengths that end up in the binaries as well as in compiler warnings/errors. Otherwise there should be no functional change. Example before: > 0000000000000000 W unsigned long boost::multi_index::detail::hashed_index<mempoolentry_txid, SaltedTxidHasher, std::equal_to<uint256>, boost::multi_index::detail::nth_layer<1, CTxMemPoolEntry, boost::multi_index::indexed_by<boost::multi_index::hashed_unique<mempoolentry_txid, SaltedTxidHasher, mpl_::na, mpl_::na>, boost::multi_index::hashed_unique<boost::multi_index::tag<index_by_wtxid, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, mempoolentry_wtxid, SaltedTxidHasher, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<descendant_score, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<CTxMemPoolEntry>, CompareTxMemPoolEntryByDescendantScore>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<entry_time, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<CTxMemPoolEntry>, CompareTxMemPoolEntryByEntryTime>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<ancestor_score, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<CTxMemPoolEntry>, CompareTxMemPoolEntryByAncestorFee>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<CTxMemPoolEntry> >, boost::mpl::vector0<mpl_::na>, boost::multi_index::detail::hashed_unique_tag>::count<uint256, SaltedTxidHasher, std::equal_to<uint256> >(uint256 const&, SaltedTxidHasher const&, std::equal_to<uint256> const&, mpl_::bool_<false>) const After: > 0000000000000000 W unsigned long boost::multi_index::detail::hashed_index<mempoolentry_txid, SaltedTxidHasher, std::equal_to<uint256>, boost::multi_index::detail::nth_layer<1, CTxMemPoolEntry, CTxMemPool::CTxMemPoolEntry_Indicies, std::allocator<CTxMemPoolEntry> >, boost::mpl::vector0<mpl_::na>, boost::multi_index::detail::hashed_unique_tag>::count<uint256, SaltedTxidHasher, std::equal_to<uint256> >(uint256 const&, SaltedTxidHasher const&, std::equal_to<uint256> const&, mpl_::bool_<false>) const ACKs for top commit: glozow: ACK `a3cb309e7c`, TIL, makes sense to me TheCharlatan: ACK `a3cb309e7c` fanquake: ACK `a3cb309e7c` Tree-SHA512: f6bb3d133daec126cf064ed6fe4457f457c0cfdbea28778c8ff426be7b41b271ada2d790c6b4129ca22156182c99aaf287e3aa9fb6b076ee55946da40e06e5d8	3 months ago
Ava Chow	da083d4bbd	Merge bitcoin/bitcoin#29775 : Testnet4 including PoW difficulty adjustment fix `6bfa26048d` testnet: Add timewarp attack prevention for Testnet4 (Fabian Jahr) `0100907ca1` testnet: Add Testnet4 difficulty adjustment rules fix (Fabian Jahr) `74a04f9e7a` testnet: Introduce Testnet4 (Fabian Jahr) Pull request description: To supplement the [ongoing conceptual discussion about a testnet reset](https://groups.google.com/g/bitcoindev/c/9bL00vRj7OU/m/9yCPo3uUBwAJ) I have drafted a move to v4 including a fix to the difficulty adjustment mechanism, which was part of the motivation that started the discussion. Conceptual considerations: - The conceptual discussion about doing a testnet4 or softforking the fix into testnet3 is outside of the scope of this PR and I would ask reviewers to contribute their opinions on this on the ML instead. However, I am happy to adapt this PR to a softfork change on testnet3 if there is consensus for that instead. - The difficulty adjustment fix suggested here touches the `CalculateNextWorkRequired` function and uses the same logic used in `GetNextWorkRequired` to find the last previous block that was not mined with difficulty 1 under the exceptionf. An alternative fix briefly mentioned on the mailing list by Jameson Lopp would be to "restrict the special testnet minimum difficulty rule so that it can't be triggered on the block right before a difficulty retarget". That would also fix the issue but I find my suggestion here a bit more elegant. ACKs for top commit: jsarenik: tACK `6bfa26048d` achow101: ACK `6bfa26048d` murchandamus: tACK `6bfa26048d` Tree-SHA512: 0b8b69a621406a944da5be551b863d065358ba94d85dd3b80d83c412660e230ee93b27316081fbee9b4851cc4ff8585db64c7dfa26cb5148ac835663f2712c3d	3 months ago
glozow	676abd1af7	Merge bitcoin/bitcoin#30594 : docs: doc update for mempoolfullrbf default + log deprecation `1f93e3c360` add deprecation warning for mempoolfullrbf (glozow) `4400c979a3` [doc] update documentation for new mempoolfullrbf default (glozow) Pull request description: Followup to #30493. Update bips.md and policy/*.md to reflect new default rules around signaling requirements in RBF. Also, log a warning when `-mempoolfullrbf=0` that this config option is deprecated and will be removed in a future release. ACKs for top commit: petertodd: ACK `1f93e3c360` instagibbs: ACK `1f93e3c360` tdb3: ACK `1f93e3c360` Tree-SHA512: f60a9524f15cfaa4c10c40b6f62b787d3f9865aac48ca883def30efac4f8a118f1359532f1b209ea34e201f0b1c92398abc8bc1e439e6b60910cc7f75c51e9ae	3 months ago
glozow	1f93e3c360	add deprecation warning for mempoolfullrbf	3 months ago
glozow	4400c979a3	[doc] update documentation for new mempoolfullrbf default	3 months ago
Ava Chow	2987ba6637	Merge bitcoin/bitcoin#30525 : doc, rpc : `#30275` followups `fa2f26960e` [rpc, fees]: add more detail on the fee estimation modes (ismaelsadeeq) `6e7e620864` [doc]: add `30275` release notes (ismaelsadeeq) Pull request description: This PR: 1. Adds release notes for #30275 2. Describe fee estimation modes in RPC help texts ACKs for top commit: achow101: ACK `fa2f26960e` glozow: ACK `fa2f26960e` willcl-ark: ACK `fa2f26960e` tdb3: re ACK `fa2f26960e` Tree-SHA512: b8ea000b599297b954dc770137c29b47153e68644c58550a73e34b74ecb8b65e78417875481efdfdf6aab0018a9cd1d90d8baa5a015e70aca0975f6e1dc9598c	3 months ago
Ryan Ofsky	b38fb19b7e	Merge bitcoin/bitcoin#30051 : crypto, refactor: add new KeyPair class `ec973dd197` refactor: remove un-tested early returns (josibake) `72a5822d43` tests: add tests for KeyPair (josibake) `cebb08b121` refactor: move SignSchnorr to KeyPair (josibake) `c39fd39ba8` crypto: add KeyPair wrapper class (josibake) `5d507a0091` tests: add key tweak smoke test (josibake) `f14900b6e4` bench: add benchmark for signing with a taptweak (josibake) Pull request description: Broken out from #28201 --- The wallet returns an untweaked internal key for taproot outputs. If the output commits to a tree of scripts, this key needs to be tweaked with the merkle root. Even if the output does not commit to a tree of scripts, BIP341/342 recommend commiting to a hash of the public key. Previously, this logic for applying the taptweak was implemented in the `CKey::SignSchnorr` method. This PR moves introduces a KeyPair class which wraps a `secp256k1_keypair` type and refactors SignSchnorr to use this new KeyPair. The KeyPair class is created with an optional merkle_root argument and the logic from BIP341 is applied depending on the state of the merkle_root argument. The motivation for this refactor is to be able to use the tap tweak logic outside of signing, e.g. in silent payments when retrieving the private key (see #28201). Outside of silent payments, since we almost always convert a `CKey` to a `secp256k1_keypair` when doing anything with taproot keys, it seems generally useful to have a way to model this type in our code base. ACKs for top commit: paplorinc: ACK `ec973dd197` - will happily reack if you decide to apply @ismaelsadeeq's suggestions ismaelsadeeq: Code review ACK `ec973dd197` itornaza: trACK `ec973dd197` theStack: Code-review ACK `ec973dd197` Tree-SHA512: 34947e3eac39bd959807fa21b6045191fc80113bd650f6f08606e4bcd89aa17d6afd48dd034f6741ac4ff304b104fa8c1c1898e297467edcf262d5f97425da7b	3 months ago
Ava Chow	ce1c881ccc	Merge bitcoin/bitcoin#30577 : miniscript: Use `ToIntegral` instead of `ParseInt64` `6714276d72` miniscript: Use `ToIntegral` instead of `ParseInt64` (brunoerg) Pull request description: Currently, miniscript code uses `ParseInt64` function for `after`, `older`, `multi` and `thresh` fragments. It means that a leading `+` or whitespace, among other things, are accepted into the fragments. However, these cases are not useful and cause Bitcoin Core to behave differently compared to other miniscript implementations (see https://github.com/brunoerg/bitcoinfuzz/issues/34). This PR fixes it. ACKs for top commit: achow101: ACK `6714276d72` tdb3: cr ACK `6714276d72` danielabrozzoni: tACK `6714276d72` darosior: utACK `6714276d72` Tree-SHA512: d9eeb93f380f346d636513eeaf26865285e7b0907b8ed258fe1e02153a9eb69d484c82180eb1c78b0ed77ad5f0e5b244be6672c2f890b1d9fddc9e844bee6dde	3 months ago
Martin Zumsande	49d569cb1f	p2p: For assumeutxo, download snapshot chain before background chain After loading a snapshot, pindexLastCommonBlock is usually already set to some block for existing peers. That means we'd continue syncing the background chain from those peers instead of prioritising the snapshot chain, which defeats the purpose of doing assumeutxo in the first place. Only existing peers are affected by this bug.	3 months ago
Martin Zumsande	7a885518d5	p2p: Restrict downloading of blocks for snapshot chain If the best chain of the peer doesn't include the snapshot block, it is futile to download blocks from this chain, because we couldn't reorg to it. We'd also crash trying to reorg because this scenario is not handled.	3 months ago
Ryan Ofsky	bb25e0691f	Merge bitcoin/bitcoin#30485 : log: Remove NOLINT(bitcoin-unterminated-logprintf) `fa18fc7050` log: Remove NOLINT(bitcoin-unterminated-logprintf) (MarcoFalke) Pull request description: `NOLINT(bitcoin-unterminated-logprintf)` is used to document a missing trailing `\n` char in the format string. This has many issues: * It is just documentation, assuming that a trailing `\n` ends up in the formatted string. It is not enforced at compile-time, so it is brittle. * If the newline was truly missing and `NOLINT(bitcoin-unterminated-logprintf)` were used to document a "continued" line, the log stream would be racy/corrupt, because any other thread may inject a log message in the meantime. * If the newline was accidentally missing, nothing is there to correct the mistake. * The intention of all code is to always end a log line with a new line. However, historic code exists to deal with the case where the new line was missing (`m_started_new_line`). This is problematic, because the presumed dead code has to be maintained (https://github.com/bitcoin/bitcoin/pull/30386#discussion_r1682963306). Fix almost all issues by removing the `NOLINT(bitcoin-unterminated-logprintf)`, ensuring that a new line is always present. A follow-up will remove the dead logging code. ACKs for top commit: TheCharlatan: ACK `fa18fc7050` ryanofsky: Code review ACK `fa18fc7050` Tree-SHA512: bf8a83723cca84e21187658edc19612da79c34f7ef2e1f6e9353e7ba70e4ecc0a878a2ae32290045fb90cba9a44451e35341a36ef2ec1169d13592393aa4a8ca	3 months ago
merge-script	d7333ece15	Merge bitcoin/bitcoin#30590 : build: Remove unused visibility checks `bbcba09cd5` build: remove check for __declspec(dllexport) (fanquake) `37c9abdc43` build: remove check for __attribute__((visibility.. (fanquake) Pull request description: These are unused (since libbitcoinconsensus / #29648), and the current CMake port doesn't quite match behaviour, such that there's no real point in doing the check. So rather than port anything, just remove it. If these are needed again in future (i.e for kernel or similar), they can be revisted, and it might be the case that build-system level checks will not be wanted. ACKs for top commit: hebasto: ACK `bbcba09cd5`. I've verified that neither `HAVE_DEFAULT_VISIBILITY_ATTRIBUTE` nor `HAVE_DLLEXPORT_ATTRIBUTE` are used or evaluated in the current codebase. TheCharlatan: ACK `bbcba09cd5` willcl-ark: ACK `bbcba09cd5` Tree-SHA512: 332f018c50a159d2cbfd2f9ce018538fa11cf06a94e27ed42146945b86645af5881095df39cadd2f775a8ae348ebfc949d54f7eb4b62264bf48119c9f9952c20	3 months ago
Ryan Ofsky	870447fd58	Merge bitcoin/bitcoin#30212 : rename TransactionError:ALREADY_IN_CHAIN `e9de0a76b9` doc: release note for 30212 (willcl-ark) `87b1880525` rpc: clarify ALREADY_IN_CHAIN rpc errors (willcl-ark) Pull request description: Closes: #19363 Renaming this error improves clarity around the returned error both internally and externally when a transactions' outputs are already found in the utxo set (`TransactionError::ALREADY_IN_CHAIN -> TransactionError::ALREADY_IN_UTXO_SET`) ACKs for top commit: tdb3: ACK `e9de0a76b9` ismaelsadeeq: ACK `e9de0a76b9` ryanofsky: Code review ACK `e9de0a76b9`. Tree-SHA512: 7d2617200909790340951fe56a241448f9ce511900777cb2a712e8b9c0778a27d1f912b460f82335844224f1abb4322bc898ca076440959edade55c082a09237	3 months ago
Hennadii Stepanov	16d8261181	doc: Drop no longer needed workaround for WSL This change effectively reverts `4f890ba6bc`.	3 months ago
glozow	31a3ff5515	Merge bitcoin/bitcoin#30596 : fuzz: replace hardcoded numbers for bech32 limits `59c0ece0a7` fuzz: replace hardcoded numbers for bech32 limits (josibake) Pull request description: Follow-up to #30047 to replace a hardcoded value that was missed in the original PR ACKs for top commit: paplorinc: ACK `59c0ece0a7` dergoegge: utACK `59c0ece0a7` marcofleon: ACK `59c0ece0a7`. Ran the test a bit to be sure, lgtm. brunoerg: utACK `59c0ece0a7` Tree-SHA512: 89799928feb6752a533259117340b087ff7299f9bf204b165dd87708e15b99a338521f2ac9f9e1fd91dc48b93be839059768d9e68b172e36328232174d1dfa3f	3 months ago
merge-script	43740f4971	Merge bitcoin/bitcoin#30588 : depends: fix ZMQ CMake getcachesize check `a0a9a11642` depends: fix ZMQ CMake getcachesize check (fanquake) Pull request description: Fixes #30587. ACKs for top commit: maflcko: ACK `a0a9a11642` hebasto: ACK `a0a9a11642`. On Ubuntu (s390x), I was able to reproduce https://github.com/bitcoin/bitcoin/issues/30587. With this PR building `zeromq` succeeds. TheCharlatan: ACK `a0a9a11642` Tree-SHA512: 70ca50ebe8e36d5a10a2354a1fbed49f5f802ae5115e09686bccca7e5d1da35168e84a6cab40dd2c83f8918889cdfdcbd5d1cbe25273b844c8ddd21865ea6c51	3 months ago
merge-script	d928f4c47f	Merge bitcoin/bitcoin#30573 : Update libsecp256k1 subtree to latest master `9ec776adff` Revert "build: pass --with-ecmult-gen-kb=86 to secp256k1" (fanquake) `41797f8ab9` Squashed 'src/secp256k1/' changes from 4af241b320..642c885b61 (fanquake) Pull request description: Updates the libsecp256k1 subtree to `642c885b61` (which is the tag for the [`v0.5.1` release](https://github.com/bitcoin-core/secp256k1/releases/tag/v0.5.1)). Includes a handful of changes: * https://github.com/bitcoin-core/secp256k1/pull/1551 * https://github.com/bitcoin-core/secp256k1/pull/1555 * https://github.com/bitcoin-core/secp256k1/pull/1563 * https://github.com/bitcoin-core/secp256k1/pull/1564 * https://github.com/bitcoin-core/secp256k1/pull/1565 * https://github.com/bitcoin-core/secp256k1/pull/1574 Reverts `a057869aa3` given secps default has changed (https://github.com/bitcoin-core/secp256k1/pull/1563): > As a rule of thumb, the default values for configuration options should target standard desktop machines and align with Bitcoin Core's defaults, and the tests should mostly exercise the default configuration (see [#1549](https://github.com/bitcoin-core/secp256k1/issues/1549#issuecomment-2200559257)). ACKs for top commit: hebasto: ACK `9ec776adff`, I've reproduced the subtree update locally with the zero diff with this PR branch. Tree-SHA512: 903ca0ff12dcc32b6cd86aee84e19de09803d35a1ee006ce890f3761dd27f1e96fe70c7bb4c279416a96ee57c406c9627614900f0ca6f76674c0088a3d270cd2	3 months ago
josibake	59c0ece0a7	fuzz: replace hardcoded numbers for bech32 limits Use bech32::CharLimit::BECH32 and bech32::CHECKSUM_SIZE instead of hardcoded values. This is a follow-up fix for #34007 (where this file was missed)	3 months ago
Andrew Toth	589db872e1	validation: don't erase coins cache on prune flushes	3 months ago
Pieter Wuille	0e8918755f	Add linked-list test to CCoinsViewCache::SanityCheck	3 months ago
Andrew Toth	05cf4e1875	coins: move Sync logic to CoinsViewCacheCursor Erase spent cache entries and clear flags of unspent entries inside the BatchWrite loop, instead of an additional loop after BatchWrite. Co-Authored-By: Pieter Wuille <pieter@wuille.net>	3 months ago
Andrew Toth	7825b8b9ae	coins: pass linked list of flagged entries to BatchWrite BatchWrite now iterates through the linked list of flagged entries instead of the entire coinsCache map. Co-Authored-By: l0rinc <pap.lorinc@gmail.com>	3 months ago
Andrew Toth	a14edada8a	test: add cache entry linked list tests Co-Authored-By: l0rinc <pap.lorinc@gmail.com>	3 months ago

1 2 3 4 5 ...

42121 Commits (2b43c45b13ad00cfd9928a03da8a480977724cb1) All Branches Search

42121 Commits (2b43c45b13ad00cfd9928a03da8a480977724cb1)

All Branches