bitcoin

Commit Graph

Author	SHA1	Message	Date
MarcoFalke	fa584b4d01	test: Remove windows workaround in authproxy	2 years ago
MarcoFalke	fae66fceb3	test: Remove python3.5 workaround in authproxy Also, move the burden of checking for a timeout to the client and disable the timeout on the server. This should avoid intermittent issues in slow tests (for example mining_getblocktemplate_longpoll.py, or feature_dbcrash.py), or possibly when the server is running slow (for example in valgrind). There shouldn't be any downside in tests caused by a high rpcservertimeout.	2 years ago
fanquake	446c8f581c	Merge bitcoin/bitcoin#25950 : test: fix test abort for high timeout values (and `--timeout-factor 0`) `14302a4802` test: fix test abort for high timeout values (and `--timeout-factor 0`) (Sebastian Falbesoner) Pull request description: On master, the functional tests's option `--timeout-factor 0` (which according to the test docs and parameter description should disable the RPC timeouts) currently fails, same as high values like `--timeout-factor 999999`: ``` $ ./test/functional/wallet_basic.py --timeout-factor 0 2022-08-29T01:26:39.561000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_f24yxzp5 2022-08-29T01:26:40.262000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/home/honey/bitcoin/test/functional/test_framework/test_framework.py", line 549, in start_nodes node.wait_for_rpc_connection() File "/home/honey/bitcoin/test/functional/test_framework/test_node.py", line 234, in wait_for_rpc_connection rpc.getblockcount() File "/home/honey/bitcoin/test/functional/test_framework/coverage.py", line 49, in __call__ return_val = self.auth_service_proxy_instance.__call__(args, *kwargs) File "/home/honey/bitcoin/test/functional/test_framework/authproxy.py", line 142, in __call__ response, status = self._request('POST', self.__url.path, postdata.encode('utf-8')) File "/home/honey/bitcoin/test/functional/test_framework/authproxy.py", line 107, in _request self.__conn.request(method, path, postdata, headers) File "/usr/local/lib/python3.9/http/client.py", line 1285, in request self._send_request(method, url, body, headers, encode_chunked) File "/usr/local/lib/python3.9/http/client.py", line 1331, in _send_request self.endheaders(body, encode_chunked=encode_chunked) File "/usr/local/lib/python3.9/http/client.py", line 1280, in endheaders self._send_output(message_body, encode_chunked=encode_chunked) File "/usr/local/lib/python3.9/http/client.py", line 1040, in _send_output self.send(msg) File "/usr/local/lib/python3.9/http/client.py", line 980, in send self.connect() File "/usr/local/lib/python3.9/http/client.py", line 946, in connect self.sock = self._create_connection( File "/usr/local/lib/python3.9/socket.py", line 844, in create_connection raise err File "/usr/local/lib/python3.9/socket.py", line 832, in create_connection sock.connect(sa) OSError: [Errno 22] Invalid argument ``` This is caused by a high timeout value that Python's HTTP(S) client library can't cope with. Fix this by clamping down the connection's set timeout value in AuthProxy. The change can easily be tested by running an arbitrary test with `--timeout-factor 0` on master (should fail), on this PR (should pass) and on this PR with the clamping value increased by 1 (should fail). // EDIT: The behaviour was observed on OpenBSD 7.1 and Python 3.9.12. ACKs for top commit: MarcoFalke: lgtm ACK `14302a4802` Tree-SHA512: 6469e8ac699f1bb7dea11d5fb8b3ae54d895bb908570587c5631144cd41fe980ca0b1e6d0b7bfa07983307cba15fb26ae92e6766375672bf5be838d8e5422dbc	2 years ago
Sebastian Falbesoner	14302a4802	test: fix test abort for high timeout values (and `--timeout-factor 0`)	2 years ago
Ryan Ofsky	d8b12a75db	rpc: Allow named and positional arguments to be used together It's nice to be able to use named options and positional arguments together. Most shell tools accept both, and python functions combine options and arguments allowing them to be passed with even more flexibility. This change adds support for python's approach so as a motivating example: bitcoin-cli -named createwallet wallet_name=mywallet load_on_startup=1 Can be shortened to: bitcoin-cli -named createwallet mywallet load_on_startup=1 JSON-RPC standard doesn't have a convention for passing named and positional parameters together, so this implementation makes one up and interprets any unused "args" named parameter as a positional parameter array.	2 years ago
MarcoFalke	fad02274ba	test: Remove Windows workaround in authproxy This reverts commit `fab9899204`.	3 years ago
Ivan Metlushko	3a7e79478a	test: retry when write to a socket fails on macOS If the socket is tearing down macOS will return EPROTOTYPE instead of EPIPE. Because python doesn't handle this internally we have to do a workaround and retry the request. See https://bugs.python.org/issue33450	4 years ago
MarcoFalke	fab9899204	test: Try once more when RPC connection fails on Windows	5 years ago
MarcoFalke	faa655731e	test: Document why connection is re-constructed on windows	5 years ago
MarcoFalke	fa9f4f663c	test: Remove python 3.4 workaround	5 years ago
MarcoFalke	fa078984c9	test: Properly log named args in authproxy	6 years ago
Daniel Kraft	8f5d9431a3	Add regtests for HTTP status codes. This adds explicit tests for the returned HTTP status codes to interface_rpc.py (for error cases) and the HTTP JSON-RPC client in general for success. PR 15381 brought up discussion about the HTTP status codes in general, and the general opinion was that the current choice may not be ideal but should not be changed to preserve compatibility with existing JSON-RPC clients. Thus it makes sense to actually test the current status to ensure this desired compatibility is not broken accidentally.	6 years ago
Chun Kuan Lee	2148c36b6e	tests: Make it possible to run functional tests on Windows	6 years ago
practicalswift	169f3e8637	Remove assigned but never used local variables	7 years ago
John Newbery	f893085325	[tests] Don't subclass from object for Python 3	7 years ago
John Newbery	8f9e3627ef	[tests] authproxy.py: tidy up __init__()	7 years ago
John Newbery	323d8f61e9	[tests] fix flake8 warnings in authproxy.py	7 years ago
John Newbery	fc0176d01e	[tests] use python3 for authproxy.py	7 years ago
Russell Yanofsky	9f67646f17	Make AuthServiceProxy._batch method usable Split off AuthServiceProxy.get_request method to make it easier to batch RPC requests without duplicating code and remove leading underscore from _batch method. This does not change any existing behavior.	7 years ago
John Newbery	979d0b8a65	[tests] [wallet] Add wallet endpoint support to authproxy	7 years ago
Wladimir J. van der Laan	20187e4ad0	test: Add elapsed time to RPC tracing Add elapsed time to output of `--tracerpc`. To find out why tests are slow.	8 years ago
John Newbery	c28ee91db0	Rename rpc-tests directory to functional	8 years ago

22 Commits (26cb32c02d76d6635c67942a5eeb70a6199df69d)