diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cpp index 6767e6fc518..894748a1355 100644 --- a/src/node/blockstorage.cpp +++ b/src/node/blockstorage.cpp @@ -38,45 +38,54 @@ static constexpr uint8_t DB_LAST_BLOCK{'l'}; // CBlockTreeDB::DB_TXINDEX{'t'} // CBlockTreeDB::ReadFlag("txindex") -bool CBlockTreeDB::ReadBlockFileInfo(int nFile, CBlockFileInfo &info) { +bool CBlockTreeDB::ReadBlockFileInfo(int nFile, CBlockFileInfo& info) +{ return Read(std::make_pair(DB_BLOCK_FILES, nFile), info); } -bool CBlockTreeDB::WriteReindexing(bool fReindexing) { - if (fReindexing) +bool CBlockTreeDB::WriteReindexing(bool fReindexing) +{ + if (fReindexing) { return Write(DB_REINDEX_FLAG, uint8_t{'1'}); - else + } else { return Erase(DB_REINDEX_FLAG); + } } -void CBlockTreeDB::ReadReindexing(bool &fReindexing) { +void CBlockTreeDB::ReadReindexing(bool& fReindexing) +{ fReindexing = Exists(DB_REINDEX_FLAG); } -bool CBlockTreeDB::ReadLastBlockFile(int &nFile) { +bool CBlockTreeDB::ReadLastBlockFile(int& nFile) +{ return Read(DB_LAST_BLOCK, nFile); } -bool CBlockTreeDB::WriteBatchSync(const std::vector >& fileInfo, int nLastFile, const std::vector& blockinfo) { +bool CBlockTreeDB::WriteBatchSync(const std::vector>& fileInfo, int nLastFile, const std::vector& blockinfo) +{ CDBBatch batch(*this); - for (std::vector >::const_iterator it=fileInfo.begin(); it != fileInfo.end(); it++) { - batch.Write(std::make_pair(DB_BLOCK_FILES, it->first), *it->second); + for (const auto& [file, info] : fileInfo) { + batch.Write(std::make_pair(DB_BLOCK_FILES, file), *info); } batch.Write(DB_LAST_BLOCK, nLastFile); - for (std::vector::const_iterator it=blockinfo.begin(); it != blockinfo.end(); it++) { - batch.Write(std::make_pair(DB_BLOCK_INDEX, (*it)->GetBlockHash()), CDiskBlockIndex(*it)); + for (const CBlockIndex* bi : blockinfo) { + batch.Write(std::make_pair(DB_BLOCK_INDEX, bi->GetBlockHash()), CDiskBlockIndex{bi}); } return WriteBatch(batch, true); } -bool CBlockTreeDB::WriteFlag(const std::string &name, bool fValue) { +bool CBlockTreeDB::WriteFlag(const std::string& name, bool fValue) +{ return Write(std::make_pair(DB_FLAG, name), fValue ? uint8_t{'1'} : uint8_t{'0'}); } -bool CBlockTreeDB::ReadFlag(const std::string &name, bool &fValue) { +bool CBlockTreeDB::ReadFlag(const std::string& name, bool& fValue) +{ uint8_t ch; - if (!Read(std::make_pair(DB_FLAG, name), ch)) + if (!Read(std::make_pair(DB_FLAG, name), ch)) { return false; + } fValue = ch == uint8_t{'1'}; return true; }