mingw: Document mode wbx workaround

pull/28052/head
MarcoFalke 4 months ago
parent fa359255fe
commit fa895c7283
No known key found for this signature in database

@ -1164,7 +1164,13 @@ static auto InitBlocksdirXorKey(const BlockManager::Options& opts)
xor_key_file >> xor_key;
} else {
// Create initial or missing xor key file
AutoFile xor_key_file{fsbridge::fopen(xor_key_path, "wbx")};
AutoFile xor_key_file{fsbridge::fopen(xor_key_path,
#ifdef __MINGW64__
"wb" // Temporary workaround for https://github.com/bitcoin/bitcoin/issues/30210
#else
"wbx"
#endif
)};
xor_key_file << xor_key;
}
// If the user disabled the key, it must be zero.

@ -30,8 +30,7 @@ BOOST_AUTO_TEST_CASE(xor_file)
}
{
#ifdef __MINGW64__
// Our usage of mingw-w64 and the msvcrt runtime does not support
// the x modifier for the _wfopen().
// Temporary workaround for https://github.com/bitcoin/bitcoin/issues/30210
const char* mode = "wb";
#else
const char* mode = "wbx";

Loading…
Cancel
Save