From 995dd89d884bda3fb5ca1885c5887d989cd2cad3 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Fri, 24 Aug 2018 11:14:45 -0400 Subject: [PATCH 1/2] [Tests] Make combine_logs.py handle multi-line logs combine_logs.py currently inserts additional newlines into multi-line log messages, and doesn't color them properly. Fix both of those. --- test/functional/combine_logs.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/functional/combine_logs.py b/test/functional/combine_logs.py index 91b6415a7cd..f5eb4c45376 100755 --- a/test/functional/combine_logs.py +++ b/test/functional/combine_logs.py @@ -79,7 +79,8 @@ def get_log_events(source, logfile): timestamp = time_match.group() # if it doesn't have a timestamp, it's a continuation line of the previous log. else: - event += "\n" + line + # Add the line. Prefix with space equivalent to the source + timestamp so log lines are aligned + event += " " + line # Flush the final event yield LogEvent(timestamp=timestamp, source=source, event=event.rstrip()) except FileNotFoundError: @@ -98,7 +99,11 @@ def print_logs(log_events, color=False, html=False): colors["reset"] = "\033[0m" # Reset font color for event in log_events: - print("{0} {1: <5} {2} {3}".format(colors[event.source.rstrip()], event.source, event.event, colors["reset"])) + lines = event.event.splitlines() + print("{0} {1: <5} {2} {3}".format(colors[event.source.rstrip()], event.source, lines[0], colors["reset"])) + if len(lines) > 1: + for line in lines[1:]: + print("{0}{1}{2}".format(colors[event.source.rstrip()], line, colors["reset"])) else: try: From 16e288acdd61fa5fa5e39f3936fb50499f82c085 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Mon, 27 Aug 2018 14:16:33 -0400 Subject: [PATCH 2/2] test padding non micro timestamps --- test/functional/combine_logs.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/functional/combine_logs.py b/test/functional/combine_logs.py index f5eb4c45376..3759913e442 100755 --- a/test/functional/combine_logs.py +++ b/test/functional/combine_logs.py @@ -13,7 +13,7 @@ import re import sys # Matches on the date format at the start of the log event -TIMESTAMP_PATTERN = re.compile(r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{6}Z") +TIMESTAMP_PATTERN = re.compile(r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d{6})?Z") LogEvent = namedtuple('LogEvent', ['timestamp', 'source', 'event']) @@ -75,8 +75,13 @@ def get_log_events(source, logfile): if time_match: if event: yield LogEvent(timestamp=timestamp, source=source, event=event.rstrip()) - event = line timestamp = time_match.group() + if time_match.group(1) is None: + # timestamp does not have microseconds. Add zeroes. + timestamp_micro = timestamp.replace("Z", ".000000Z") + line = line.replace(timestamp, timestamp_micro) + timestamp = timestamp_micro + event = line # if it doesn't have a timestamp, it's a continuation line of the previous log. else: # Add the line. Prefix with space equivalent to the source + timestamp so log lines are aligned