From d7fd766feb2f579bdba0e778bacdeb13103e8282 Mon Sep 17 00:00:00 2001 From: kevkevinpal Date: Wed, 23 Oct 2024 09:58:48 -0400 Subject: [PATCH] test: added test to assert TX decode rpc error on submitpackage rpc --- test/functional/rpc_packages.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/functional/rpc_packages.py b/test/functional/rpc_packages.py index ef2f66b3a01..539ff155cff 100755 --- a/test/functional/rpc_packages.py +++ b/test/functional/rpc_packages.py @@ -369,6 +369,14 @@ class RPCPackagesTest(BitcoinTestFramework): def test_submitpackage(self): node = self.nodes[0] + self.log.info("Submitpackage only allows valid hex inputs") + valid_tx_list = self.wallet.create_self_transfer_chain(chain_length=2) + hex_list = [valid_tx_list[0]["hex"][:-1] + 'X', valid_tx_list[1]["hex"]] + txid_list = [valid_tx_list[0]["txid"], valid_tx_list[1]["txid"]] + assert_raises_rpc_error(-22, "TX decode failed:", node.submitpackage, hex_list) + assert txid_list[0] not in node.getrawmempool() + assert txid_list[1] not in node.getrawmempool() + self.log.info("Submitpackage valid packages with 1 child and some number of parents") for num_parents in [1, 2, 24]: self.test_submit_child_with_parents(num_parents, False)