|
|
|
|
@ -27,10 +27,6 @@ TxRequestTracker& TxDownloadManager::GetTxRequestRef()
|
|
|
|
|
{
|
|
|
|
|
return m_impl->m_txrequest;
|
|
|
|
|
}
|
|
|
|
|
CRollingBloomFilter& TxDownloadManager::RecentRejectsFilter()
|
|
|
|
|
{
|
|
|
|
|
return m_impl->RecentRejectsFilter();
|
|
|
|
|
}
|
|
|
|
|
CRollingBloomFilter& TxDownloadManager::RecentRejectsReconsiderableFilter()
|
|
|
|
|
{
|
|
|
|
|
return m_impl->RecentRejectsReconsiderableFilter();
|
|
|
|
|
@ -79,6 +75,10 @@ void TxDownloadManager::MempoolAcceptedTx(const CTransactionRef& tx)
|
|
|
|
|
{
|
|
|
|
|
m_impl->MempoolAcceptedTx(tx);
|
|
|
|
|
}
|
|
|
|
|
RejectedTxTodo TxDownloadManager::MempoolRejectedTx(const CTransactionRef& ptx, const TxValidationState& state, NodeId nodeid, bool first_time_failure)
|
|
|
|
|
{
|
|
|
|
|
return m_impl->MempoolRejectedTx(ptx, state, nodeid, first_time_failure);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TxDownloadManagerImpl
|
|
|
|
|
void TxDownloadManagerImpl::ActiveTipChange()
|
|
|
|
|
@ -167,6 +167,8 @@ void TxDownloadManagerImpl::DisconnectedPeer(NodeId nodeid)
|
|
|
|
|
bool TxDownloadManagerImpl::AddTxAnnouncement(NodeId peer, const GenTxid& gtxid, std::chrono::microseconds now, bool p2p_inv)
|
|
|
|
|
{
|
|
|
|
|
// If this is an inv received from a peer and we already have it, we can drop it.
|
|
|
|
|
// If this is a request for the parent of an orphan, we don't drop transactions that we already have. In particular,
|
|
|
|
|
// we *do* want to request parents that are in m_lazy_recent_rejects_reconsiderable, since they can be CPFP'd.
|
|
|
|
|
if (p2p_inv && AlreadyHaveTx(gtxid, /*include_reconsiderable=*/true)) return true;
|
|
|
|
|
|
|
|
|
|
auto it = m_peer_info.find(peer);
|
|
|
|
|
@ -288,4 +290,155 @@ void TxDownloadManagerImpl::MempoolAcceptedTx(const CTransactionRef& tx)
|
|
|
|
|
// If it came from the orphanage, remove it. No-op if the tx is not in txorphanage.
|
|
|
|
|
m_orphanage.EraseTx(tx->GetWitnessHash());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
node::RejectedTxTodo TxDownloadManagerImpl::MempoolRejectedTx(const CTransactionRef& ptx, const TxValidationState& state, NodeId nodeid, bool first_time_failure)
|
|
|
|
|
{
|
|
|
|
|
const CTransaction& tx{*ptx};
|
|
|
|
|
// Results returned to caller
|
|
|
|
|
// Whether we should call AddToCompactExtraTransactions at the end
|
|
|
|
|
bool add_extra_compact_tx{first_time_failure};
|
|
|
|
|
// Hashes to pass to AddKnownTx later
|
|
|
|
|
std::vector<uint256> unique_parents;
|
|
|
|
|
// Populated if failure is reconsiderable and eligible package is found.
|
|
|
|
|
std::optional<node::PackageToValidate> package_to_validate;
|
|
|
|
|
|
|
|
|
|
if (state.GetResult() == TxValidationResult::TX_MISSING_INPUTS) {
|
|
|
|
|
// Only process a new orphan if this is a first time failure, as otherwise it must be either
|
|
|
|
|
// already in orphanage or from 1p1c processing.
|
|
|
|
|
if (first_time_failure) {
|
|
|
|
|
bool fRejectedParents = false; // It may be the case that the orphans parents have all been rejected
|
|
|
|
|
|
|
|
|
|
// Deduplicate parent txids, so that we don't have to loop over
|
|
|
|
|
// the same parent txid more than once down below.
|
|
|
|
|
unique_parents.reserve(tx.vin.size());
|
|
|
|
|
for (const CTxIn& txin : tx.vin) {
|
|
|
|
|
// We start with all parents, and then remove duplicates below.
|
|
|
|
|
unique_parents.push_back(txin.prevout.hash);
|
|
|
|
|
}
|
|
|
|
|
std::sort(unique_parents.begin(), unique_parents.end());
|
|
|
|
|
unique_parents.erase(std::unique(unique_parents.begin(), unique_parents.end()), unique_parents.end());
|
|
|
|
|
|
|
|
|
|
// Distinguish between parents in m_lazy_recent_rejects and m_lazy_recent_rejects_reconsiderable.
|
|
|
|
|
// We can tolerate having up to 1 parent in m_lazy_recent_rejects_reconsiderable since we
|
|
|
|
|
// submit 1p1c packages. However, fail immediately if any are in m_lazy_recent_rejects.
|
|
|
|
|
std::optional<uint256> rejected_parent_reconsiderable;
|
|
|
|
|
for (const uint256& parent_txid : unique_parents) {
|
|
|
|
|
if (RecentRejectsFilter().contains(parent_txid)) {
|
|
|
|
|
fRejectedParents = true;
|
|
|
|
|
break;
|
|
|
|
|
} else if (RecentRejectsReconsiderableFilter().contains(parent_txid) &&
|
|
|
|
|
!m_opts.m_mempool.exists(GenTxid::Txid(parent_txid))) {
|
|
|
|
|
// More than 1 parent in m_lazy_recent_rejects_reconsiderable: 1p1c will not be
|
|
|
|
|
// sufficient to accept this package, so just give up here.
|
|
|
|
|
if (rejected_parent_reconsiderable.has_value()) {
|
|
|
|
|
fRejectedParents = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
rejected_parent_reconsiderable = parent_txid;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (!fRejectedParents) {
|
|
|
|
|
const auto current_time{GetTime<std::chrono::microseconds>()};
|
|
|
|
|
|
|
|
|
|
for (const uint256& parent_txid : unique_parents) {
|
|
|
|
|
// Here, we only have the txid (and not wtxid) of the
|
|
|
|
|
// inputs, so we only request in txid mode, even for
|
|
|
|
|
// wtxidrelay peers.
|
|
|
|
|
// Eventually we should replace this with an improved
|
|
|
|
|
// protocol for getting all unconfirmed parents.
|
|
|
|
|
const auto gtxid{GenTxid::Txid(parent_txid)};
|
|
|
|
|
// Exclude m_lazy_recent_rejects_reconsiderable: the missing parent may have been
|
|
|
|
|
// previously rejected for being too low feerate. This orphan might CPFP it.
|
|
|
|
|
if (!AlreadyHaveTx(gtxid, /*include_reconsiderable=*/false)) {
|
|
|
|
|
AddTxAnnouncement(nodeid, gtxid, current_time, /*p2p_inv=*/false);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Potentially flip add_extra_compact_tx to false if AddTx returns false because the tx was already there
|
|
|
|
|
add_extra_compact_tx &= m_orphanage.AddTx(ptx, nodeid);
|
|
|
|
|
|
|
|
|
|
// Once added to the orphan pool, a tx is considered AlreadyHave, and we shouldn't request it anymore.
|
|
|
|
|
m_txrequest.ForgetTxHash(tx.GetHash());
|
|
|
|
|
m_txrequest.ForgetTxHash(tx.GetWitnessHash());
|
|
|
|
|
|
|
|
|
|
// DoS prevention: do not allow m_orphanage to grow unbounded (see CVE-2012-3789)
|
|
|
|
|
m_orphanage.LimitOrphans(m_opts.m_max_orphan_txs, m_opts.m_rng);
|
|
|
|
|
} else {
|
|
|
|
|
unique_parents.clear();
|
|
|
|
|
LogDebug(BCLog::MEMPOOL, "not keeping orphan with rejected parents %s (wtxid=%s)\n",
|
|
|
|
|
tx.GetHash().ToString(),
|
|
|
|
|
tx.GetWitnessHash().ToString());
|
|
|
|
|
// We will continue to reject this tx since it has rejected
|
|
|
|
|
// parents so avoid re-requesting it from other peers.
|
|
|
|
|
// Here we add both the txid and the wtxid, as we know that
|
|
|
|
|
// regardless of what witness is provided, we will not accept
|
|
|
|
|
// this, so we don't need to allow for redownload of this txid
|
|
|
|
|
// from any of our non-wtxidrelay peers.
|
|
|
|
|
RecentRejectsFilter().insert(tx.GetHash().ToUint256());
|
|
|
|
|
RecentRejectsFilter().insert(tx.GetWitnessHash().ToUint256());
|
|
|
|
|
m_txrequest.ForgetTxHash(tx.GetHash());
|
|
|
|
|
m_txrequest.ForgetTxHash(tx.GetWitnessHash());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else if (state.GetResult() == TxValidationResult::TX_WITNESS_STRIPPED) {
|
|
|
|
|
add_extra_compact_tx = false;
|
|
|
|
|
} else {
|
|
|
|
|
// We can add the wtxid of this transaction to our reject filter.
|
|
|
|
|
// Do not add txids of witness transactions or witness-stripped
|
|
|
|
|
// transactions to the filter, as they can have been malleated;
|
|
|
|
|
// adding such txids to the reject filter would potentially
|
|
|
|
|
// interfere with relay of valid transactions from peers that
|
|
|
|
|
// do not support wtxid-based relay. See
|
|
|
|
|
// https://github.com/bitcoin/bitcoin/issues/8279 for details.
|
|
|
|
|
// We can remove this restriction (and always add wtxids to
|
|
|
|
|
// the filter even for witness stripped transactions) once
|
|
|
|
|
// wtxid-based relay is broadly deployed.
|
|
|
|
|
// See also comments in https://github.com/bitcoin/bitcoin/pull/18044#discussion_r443419034
|
|
|
|
|
// for concerns around weakening security of unupgraded nodes
|
|
|
|
|
// if we start doing this too early.
|
|
|
|
|
if (state.GetResult() == TxValidationResult::TX_RECONSIDERABLE) {
|
|
|
|
|
// If the result is TX_RECONSIDERABLE, add it to m_lazy_recent_rejects_reconsiderable
|
|
|
|
|
// because we should not download or submit this transaction by itself again, but may
|
|
|
|
|
// submit it as part of a package later.
|
|
|
|
|
RecentRejectsReconsiderableFilter().insert(ptx->GetWitnessHash().ToUint256());
|
|
|
|
|
|
|
|
|
|
if (first_time_failure) {
|
|
|
|
|
// When a transaction fails for TX_RECONSIDERABLE, look for a matching child in the
|
|
|
|
|
// orphanage, as it is possible that they succeed as a package.
|
|
|
|
|
LogDebug(BCLog::TXPACKAGES, "tx %s (wtxid=%s) failed but reconsiderable, looking for child in orphanage\n",
|
|
|
|
|
ptx->GetHash().ToString(), ptx->GetWitnessHash().ToString());
|
|
|
|
|
package_to_validate = Find1P1CPackage(ptx, nodeid);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
RecentRejectsFilter().insert(ptx->GetWitnessHash().ToUint256());
|
|
|
|
|
}
|
|
|
|
|
m_txrequest.ForgetTxHash(ptx->GetWitnessHash());
|
|
|
|
|
// If the transaction failed for TX_INPUTS_NOT_STANDARD,
|
|
|
|
|
// then we know that the witness was irrelevant to the policy
|
|
|
|
|
// failure, since this check depends only on the txid
|
|
|
|
|
// (the scriptPubKey being spent is covered by the txid).
|
|
|
|
|
// Add the txid to the reject filter to prevent repeated
|
|
|
|
|
// processing of this transaction in the event that child
|
|
|
|
|
// transactions are later received (resulting in
|
|
|
|
|
// parent-fetching by txid via the orphan-handling logic).
|
|
|
|
|
// We only add the txid if it differs from the wtxid, to avoid wasting entries in the
|
|
|
|
|
// rolling bloom filter.
|
|
|
|
|
if (state.GetResult() == TxValidationResult::TX_INPUTS_NOT_STANDARD && ptx->HasWitness()) {
|
|
|
|
|
RecentRejectsFilter().insert(ptx->GetHash().ToUint256());
|
|
|
|
|
m_txrequest.ForgetTxHash(ptx->GetHash());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// If the tx failed in ProcessOrphanTx, it should be removed from the orphanage unless the
|
|
|
|
|
// tx was still missing inputs. If the tx was not in the orphanage, EraseTx does nothing and returns 0.
|
|
|
|
|
if (state.GetResult() != TxValidationResult::TX_MISSING_INPUTS && m_orphanage.EraseTx(ptx->GetWitnessHash()) > 0) {
|
|
|
|
|
LogDebug(BCLog::TXPACKAGES, " removed orphan tx %s (wtxid=%s)\n", ptx->GetHash().ToString(), ptx->GetWitnessHash().ToString());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return RejectedTxTodo{
|
|
|
|
|
.m_should_add_extra_compact_tx = add_extra_compact_tx,
|
|
|
|
|
.m_unique_parents = std::move(unique_parents),
|
|
|
|
|
.m_package_to_validate = std::move(package_to_validate)
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
} // namespace node
|
|
|
|
|
|
glozow
7 months ago