mirror of https://github.com/bitcoin/bitcoin
Merge bitcoin/bitcoin#29671: index: avoid "failed to commit" errors on initialization
pull/29684/mergef65b0f6401
index: Move last_locator_write_time and logging to end of threadsync loop (Fabian Jahr) Pull request description: In the index sync thread, when initializing an index for the first time, stop callng BaseIndex::Commit when m_best_block_index is null, to avoid a spurious "failed to commit" error from that function. This error started happening in commit7878f97bf1
from https://github.com/bitcoin/bitcoin/pull/25494 and was reported by pstratem in https://github.com/bitcoin/bitcoin/pull/26903 with an alternate fix. ACKs for top commit: achow101: ACKf65b0f6401
ryanofsky: Code review ACKf65b0f6401
. Just moved log "Syncing" log line since last commit to avoid having to call now() twice. furszy: ACKf65b0f6401
TheCharlatan: ACKf65b0f6401
Tree-SHA512: afa8f05786318d36346d167ff53ea0b3bc8abdb0ad04465d199dc3eb91e9f837369e24fcb7e24b5757b02d698ec504e61da6ac365eaf006c874fc07a424a7e20
commit
bf1b6383db
Loading…
Reference in new issue