From 83a0bb7cc9907dbe089409ed5a417277ed63ed95 Mon Sep 17 00:00:00 2001 From: Carl Dong Date: Tue, 8 Feb 2022 17:06:21 -0500 Subject: [PATCH] build: Separate lib_LTLIBRARIES initialization Set lib_LTLIBRARIES with '=' to an empty value at the top of the Makefile.am and append to it from the library-local block for readability. Here's the error you get if you don't set lib_LTLIBRARIES to be empty: error: lib_LTLIBRARIES must be set with '=' before using '+=' [META] In a subsequent commit, we're going to introduce a library and append it to lib_LTLIBRARIES in its local block, this makes things more readable. --- src/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1b15cd109c1..d074e6314eb 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -15,7 +15,7 @@ AM_LIBTOOLFLAGS = --preserve-dup-deps PTHREAD_FLAGS = $(PTHREAD_CFLAGS) $(PTHREAD_LIBS) EXTRA_LIBRARIES = -lib_LTLIBRARIES = $(LIBBITCOINCONSENSUS) +lib_LTLIBRARIES = noinst_LTLIBRARIES = bin_PROGRAMS = @@ -895,6 +895,8 @@ bitcoin_chainstate-clientversion.$(OBJEXT): obj/build.h # bitcoinconsensus library # if BUILD_BITCOIN_LIBS +lib_LTLIBRARIES += $(LIBBITCOINCONSENSUS) + include_HEADERS = script/bitcoinconsensus.h libbitcoinconsensus_la_SOURCES = support/cleanse.cpp $(crypto_libbitcoin_crypto_base_la_SOURCES) $(libbitcoin_consensus_a_SOURCES)