From fac05178366a1c9100b1d19d66fb669d7266f306 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Thu, 5 Nov 2020 11:35:28 +0100 Subject: [PATCH 1/2] travis: Remove s390x build The build didn't find too many issues, and they are generally only endianness related, so easy to fix if they do make it into the main developement branch. With travis migrating its service, it fails too often intermittently. It might be more appropriate to run it manually once before every release. --- .travis.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5c8049aada..55b34ae422 100644 --- a/.travis.yml +++ b/.travis.yml @@ -72,13 +72,6 @@ jobs: FILE_ENV="./ci/test/00_setup_env_arm.sh" QEMU_USER_CMD="" - - stage: test - name: 'S390x [GOAL: install] [buster] [unit tests, functional tests]' - arch: s390x # Can disable QEMU_USER_CMD and run the tests natively without qemu - env: >- - FILE_ENV="./ci/test/00_setup_env_s390x.sh" - QEMU_USER_CMD="" - - stage: test name: 'Win64 [GOAL: deploy] [unit tests, no gui, no boost::process, no functional tests]' env: >- From fa2c3c0d96b48bc1685d84186552f72e3609a331 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Thu, 5 Nov 2020 11:19:01 +0100 Subject: [PATCH 2/2] ci: Set LC_ALL=C to allow running the s390x tests in qemu Without the fix, the tests immediately abort: terminate called after throwing an instance of 'std::runtime_error' what(): locale::facet::_S_create_c_locale name not valid ./qt/test/test_bitcoin-qt: line 2: 116150 Aborted --- ci/test/00_setup_env_s390x.sh | 1 + ci/test/06_script_b.sh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ci/test/00_setup_env_s390x.sh b/ci/test/00_setup_env_s390x.sh index fe330920d0..accbd07e22 100644 --- a/ci/test/00_setup_env_s390x.sh +++ b/ci/test/00_setup_env_s390x.sh @@ -20,6 +20,7 @@ fi export CONTAINER_NAME=ci_s390x export DOCKER_NAME_TAG="debian:buster" export RUN_UNIT_TESTS=true +export TEST_RUNNER_ENV="LC_ALL=C" export RUN_FUNCTIONAL_TESTS=true export GOAL="install" export BITCOIN_CONFIG="--enable-reduce-exports --with-incompatible-bdb --with-boost-process" diff --git a/ci/test/06_script_b.sh b/ci/test/06_script_b.sh index 607a2820dd..87e9f31d0f 100755 --- a/ci/test/06_script_b.sh +++ b/ci/test/06_script_b.sh @@ -23,13 +23,13 @@ fi if [ "$RUN_UNIT_TESTS" = "true" ]; then BEGIN_FOLD unit-tests - DOCKER_EXEC DIR_UNIT_TEST_DATA=${DIR_UNIT_TEST_DATA} LD_LIBRARY_PATH=$DEPENDS_DIR/$HOST/lib make $MAKEJOBS check VERBOSE=1 + DOCKER_EXEC ${TEST_RUNNER_ENV} DIR_UNIT_TEST_DATA=${DIR_UNIT_TEST_DATA} LD_LIBRARY_PATH=$DEPENDS_DIR/$HOST/lib make $MAKEJOBS check VERBOSE=1 END_FOLD fi if [ "$RUN_UNIT_TESTS_SEQUENTIAL" = "true" ]; then BEGIN_FOLD unit-tests-seq - DOCKER_EXEC DIR_UNIT_TEST_DATA=${DIR_UNIT_TEST_DATA} LD_LIBRARY_PATH=$DEPENDS_DIR/$HOST/lib "${BASE_BUILD_DIR}/bitcoin-*/src/test/test_bitcoin*" --catch_system_errors=no -l test_suite + DOCKER_EXEC ${TEST_RUNNER_ENV} DIR_UNIT_TEST_DATA=${DIR_UNIT_TEST_DATA} LD_LIBRARY_PATH=$DEPENDS_DIR/$HOST/lib "${BASE_BUILD_DIR}/bitcoin-*/src/test/test_bitcoin*" --catch_system_errors=no -l test_suite END_FOLD fi