From 7715c847472f565ca79429db0d8505f126617878 Mon Sep 17 00:00:00 2001 From: Jeff Garzik Date: Tue, 18 Nov 2014 10:27:45 -0500 Subject: [PATCH] HTTP REST: minor fixes 1) const-ify internal helper ParseHashStr() 2) use HTTPError() helper when returning HTTP_NOT_FOUND --- src/rest.cpp | 4 ++-- src/rpcserver.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rest.cpp b/src/rest.cpp index 48c1672ae86..89075887a0b 100644 --- a/src/rest.cpp +++ b/src/rest.cpp @@ -56,7 +56,7 @@ static enum RetFormat ParseDataFormat(const string& format) return rf_names[0].rf; } -static bool ParseHashStr(string& strReq, uint256& v) +static bool ParseHashStr(const string& strReq, uint256& v) { if (!IsHex(strReq) || (strReq.size() != 64)) return false; @@ -195,7 +195,7 @@ bool HTTPReq_REST(AcceptedConnection *conn, return false; } - conn->stream() << HTTPReply(HTTP_NOT_FOUND, "", false) << std::flush; + conn->stream() << HTTPError(HTTP_NOT_FOUND, false) << std::flush; return false; } diff --git a/src/rpcserver.cpp b/src/rpcserver.cpp index d072f18e36d..8b042e60037 100644 --- a/src/rpcserver.cpp +++ b/src/rpcserver.cpp @@ -957,7 +957,7 @@ void ServiceConnection(AcceptedConnection *conn) break; } else { - conn->stream() << HTTPReply(HTTP_NOT_FOUND, "", false) << std::flush; + conn->stream() << HTTPError(HTTP_NOT_FOUND, false) << std::flush; break; } }