@ -297,10 +297,8 @@ static RPCHelpMan addnode()
} ,
[ & ] ( const RPCHelpMan & self , const JSONRPCRequest & request ) - > UniValue
{
std : : string strCommand ;
if ( ! request . params [ 1 ] . isNull ( ) )
strCommand = request . params [ 1 ] . get_str ( ) ;
if ( strCommand ! = " onetry " & & strCommand ! = " add " & & strCommand ! = " remove " ) {
const std : : string command { request . params [ 1 ] . get_str ( ) } ;
if ( command ! = " onetry " & & command ! = " add " & & command ! = " remove " ) {
throw std : : runtime_error (
self . ToString ( ) ) ;
}
@ -308,24 +306,24 @@ static RPCHelpMan addnode()
NodeContext & node = EnsureAnyNodeContext ( request . context ) ;
CConnman & connman = EnsureConnman ( node ) ;
std : : string strNode = request . params [ 0 ] . get_str ( ) ;
const std : : string node_arg { request . params [ 0 ] . get_str ( ) } ;
if ( strC ommand = = " onetry " )
if ( c ommand = = " onetry " )
{
CAddress addr ;
connman . OpenNetworkConnection ( addr , false , nullptr , strNode . c_str ( ) , ConnectionType : : MANUAL ) ;
connman . OpenNetworkConnection ( addr , /*fCountFailure=*/ false , /*grantOutbound=*/ nullptr , node_arg . c_str ( ) , ConnectionType : : MANUAL ) ;
return UniValue : : VNULL ;
}
if ( strC ommand = = " add " )
if ( c ommand = = " add " )
{
if ( ! connman . AddNode ( strNode ) ) {
if ( ! connman . AddNode ( node_arg ) ) {
throw JSONRPCError ( RPC_CLIENT_NODE_ALREADY_ADDED , " Error: Node already added " ) ;
}
}
else if ( strC ommand = = " remove " )
else if ( c ommand = = " remove " )
{
if ( ! connman . RemoveAddedNode ( strNode ) ) {
if ( ! connman . RemoveAddedNode ( node_arg ) ) {
throw JSONRPCError ( RPC_CLIENT_NODE_NOT_ADDED , " Error: Node could not be removed. It has not been added previously. " ) ;
}
}