From 5269d57e6d78e90baa0b40629f60a2d1d63e2992 Mon Sep 17 00:00:00 2001 From: glozow Date: Fri, 23 Aug 2024 16:05:19 +0100 Subject: [PATCH] [p2p] don't process orphan if in recent rejects This should never happen normally, but just in case. --- src/node/txdownloadman_impl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/txdownloadman_impl.cpp b/src/node/txdownloadman_impl.cpp index ccc6cff8940..6078f91c0a3 100644 --- a/src/node/txdownloadman_impl.cpp +++ b/src/node/txdownloadman_impl.cpp @@ -313,7 +313,7 @@ node::RejectedTxTodo TxDownloadManagerImpl::MempoolRejectedTx(const CTransaction if (state.GetResult() == TxValidationResult::TX_MISSING_INPUTS) { // Only process a new orphan if this is a first time failure, as otherwise it must be either // already in orphanage or from 1p1c processing. - if (first_time_failure) { + if (first_time_failure && !RecentRejectsFilter().contains(ptx->GetWitnessHash().ToUint256())) { bool fRejectedParents = false; // It may be the case that the orphans parents have all been rejected // Deduplicate parent txids, so that we don't have to loop over