1dc0e4bc6f rpc: remove optional from fStateStats fields (fanquake)
Pull request description:
These are no-longer optional after #26515, so remove the documentation, and no-op `fStateStats` checks.
ACKs for top commit:
dergoegge:
Code review ACK 1dc0e4bc6f
Tree-SHA512: 06d4550e866341b379bfdbc72d67d71a3b7ceceec06ebd4c5e6f178b75fe40cbf4aff51adba1bc52590e69e818cbdecb0366bf1528c59c5c3dff5bbdba8eac68
{RPCResult::Type::BOOL,"inbound","Inbound (true) or Outbound (false)"},
{RPCResult::Type::BOOL,"bip152_hb_to","Whether we selected peer as (compact blocks) high-bandwidth peer"},
{RPCResult::Type::BOOL,"bip152_hb_from","Whether peer selected us as (compact blocks) high-bandwidth peer"},
{RPCResult::Type::NUM,"startingheight",/*optional=*/true,"The starting height (block) of the peer"},
{RPCResult::Type::NUM,"presynced_headers",/*optional=*/true,"The current height of header pre-synchronization with this peer, or -1 if no low-work sync is in progress"},
{RPCResult::Type::NUM,"synced_headers",/*optional=*/true,"The last header we have in common with this peer"},
{RPCResult::Type::NUM,"synced_blocks",/*optional=*/true,"The last block we have in common with this peer"},
{RPCResult::Type::NUM,"startingheight","The starting height (block) of the peer"},
{RPCResult::Type::NUM,"presynced_headers","The current height of header pre-synchronization with this peer, or -1 if no low-work sync is in progress"},
{RPCResult::Type::NUM,"synced_headers","The last header we have in common with this peer"},
{RPCResult::Type::NUM,"synced_blocks","The last block we have in common with this peer"},
{RPCResult::Type::ARR,"inflight","",
{
{RPCResult::Type::NUM,"n","The heights of blocks we're currently asking from this peer"},
}},
{RPCResult::Type::BOOL,"addr_relay_enabled",/*optional=*/true,"Whether we participate in address relay with this peer"},
{RPCResult::Type::NUM,"addr_processed",/*optional=*/true,"The total number of addresses processed, excluding those dropped due to rate limiting"},
{RPCResult::Type::NUM,"addr_rate_limited",/*optional=*/true,"The total number of addresses dropped due to rate limiting"},
{RPCResult::Type::BOOL,"addr_relay_enabled","Whether we participate in address relay with this peer"},
{RPCResult::Type::NUM,"addr_processed","The total number of addresses processed, excluding those dropped due to rate limiting"},
{RPCResult::Type::NUM,"addr_rate_limited","The total number of addresses dropped due to rate limiting"},
{RPCResult::Type::ARR,"permissions","Any special permissions that have been granted to this peer",