From 2dd561f36124972d2364f941de9c3417c65f05b6 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Fri, 15 Nov 2019 15:33:27 -0500 Subject: [PATCH] [validation] Remove pool member from ConnectTrace It's no longer used for anything. --- src/validation.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/validation.cpp b/src/validation.cpp index 1f1585041ab..6d6ba80564c 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -2517,10 +2517,9 @@ struct PerBlockConnectTrace { class ConnectTrace { private: std::vector blocksConnected; - CTxMemPool &pool; public: - explicit ConnectTrace(CTxMemPool &_pool) : blocksConnected(1), pool(_pool) {} + explicit ConnectTrace() : blocksConnected(1) {} void BlockConnected(CBlockIndex* pindex, std::shared_ptr pblock) { assert(!blocksConnected.back().pindex); @@ -2833,7 +2832,7 @@ bool CChainState::ActivateBestChain(BlockValidationState &state, const CChainPar do { // We absolutely may not unlock cs_main until we've made forward progress // (with the exception of shutdown due to hardware issues, low disk space, etc). - ConnectTrace connectTrace(mempool); // Destructed before cs_main is unlocked + ConnectTrace connectTrace; // Destructed before cs_main is unlocked if (pindexMostWork == nullptr) { pindexMostWork = FindMostWorkChain();